[Scopes] Scope author should be able to set the number of collapsed results to show
Bug #1326470 reported by
Chris Wayne
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
The Savilerow project |
Fix Released
|
Undecided
|
Unassigned | ||
Ubuntu UX |
Fix Released
|
High
|
James Mulholland | ||
unity8 (Ubuntu) |
Fix Released
|
High
|
Michał Sawicz |
Bug Description
In a scope with horizontal card layouts, you can only show up to 2 results by default. If the scope only has 1 category, that means most of the vertical space is blank, and looks quite empty. There should either be a way to define how many rows to show, or the toolkit should show as many as will fill up the veritcal space
Related branches
lp:~saviq/unity8/drop-filtergrid
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Albert Astals Cid (community): Approve
- Michael Zanetti (community): Approve
- Leo Arias (community): Approve (code review of the autopilot bits)
- Michal Hruby (community): Approve
-
Diff: 1043 lines (+178/-449)18 files modifiedqml/Components/FilterGrid.qml (+0/-124)
qml/Components/ResponsiveGridView.qml (+2/-1)
qml/Dash/CardCarousel.qml (+2/-7)
qml/Dash/CardGrid.qml (+22/-23)
qml/Dash/CardVerticalJournal.qml (+2/-21)
qml/Dash/DashRenderer.qml (+3/-12)
qml/Dash/GenericScopeView.qml (+53/-27)
tests/autopilot/unity8/shell/emulators/dash.py (+9/-3)
tests/autopilot/unity8/shell/tests/test_emulators.py (+15/-5)
tests/mocks/Unity/fake_categories.cpp (+4/-1)
tests/mocks/Unity/fake_scope.cpp (+2/-2)
tests/mocks/Unity/fake_scope.h (+1/-1)
tests/mocks/Unity/fake_scopes.cpp (+1/-0)
tests/qmltests/CMakeLists.txt (+0/-1)
tests/qmltests/Components/tst_FilterGrid.qml (+0/-190)
tests/qmltests/Dash/tst_Dash.qml (+1/-1)
tests/qmltests/Dash/tst_DashContent.qml (+15/-6)
tests/qmltests/Dash/tst_GenericScopeView.qml (+46/-24)
Changed in ubuntu-ux: | |
status: | New → In Progress |
assignee: | nobody → Mike Nagle (mikenagle) |
tags: | added: savilerow |
Changed in ubuntu-ux: | |
status: | In Progress → Fix Committed |
tags: | added: scope-dev |
no longer affects: | unity-scopes-shell |
no longer affects: | unity-scopes-shell (Ubuntu) |
Changed in unity8: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in unity8: | |
status: | Triaged → In Progress |
Changed in unity8 (Ubuntu): | |
status: | Confirmed → In Progress |
assignee: | nobody → Michał Sawicz (saviq) |
Changed in unity8: | |
assignee: | nobody → Michał Sawicz (saviq) |
Changed in unity8: | |
status: | In Progress → Fix Released |
Changed in ubuntu-ux: | |
assignee: | Mike Nagle (mikenagle) → James Mulholland (jamesjosephmulholland) |
Changed in ubuntu-ux: | |
importance: | Undecided → High |
Changed in savilerow: | |
status: | New → Fix Released |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
summary: |
- Scope author should be able to set the number of collapsed results to - show + [Scopes] Scope author should be able to set the number of collapsed + results to show |
Changed in unity8 (Ubuntu): | |
importance: | Undecided → High |
no longer affects: | unity8 |
To post a comment you must log in.
propose that "collapsed-rows " accepts any number not just 1 or 2