[sdk] Button icons can't be colourized

Bug #1322525 reported by Michał Sawicz on 2014-05-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UX
Medium
Jouni Helminen
ubuntu-ui-toolkit (Ubuntu)
Medium
Unassigned

Bug Description

The Button icons are not / can't be colourized, which means if you want to use a Button, its icon will not be colourized.

In general I think our icon story is a bit messy... related bug #1284233.

I think we should only support the "image://theme/foo" of specifying icons, and whenever we encounter image://theme in the source, we should disable the shape and colourize based on the palette.

ProblemType: Bug
DistroRelease: Ubuntu 14.10
Package: qtdeclarative5-ubuntu-ui-toolkit-plugin 0.1.46+14.10.20140520-0ubuntu1
ProcVersionSignature: Ubuntu 3.15.0-1.5-generic 3.15.0-rc5
Uname: Linux 3.15.0-1-generic x86_64
NonfreeKernelModules: nvidia wl
ApportVersion: 2.14.2-0ubuntu4
Architecture: amd64
CurrentDesktop: Unity
Date: Fri May 23 10:36:46 2014
SourcePackage: ubuntu-ui-toolkit
UpgradeStatus: No upgrade log present (probably fresh install)

Michał Sawicz (saviq) wrote :
Tim Peeters (tpeeters) wrote :

the amd64 and apport-bug tags seem wrong?

tags: added: icon
Tim Peeters (tpeeters) wrote :

so, the proposal is to give he icons automatically the color of the palette foreground?

Note that buttons can be given any color, and that this color may be a bad combination with the palette foreground color.

What are the use cases where you need this?

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Incomplete
Changed in ubuntu-ui-toolkit:
importance: Undecided → Medium
Tim Peeters (tpeeters) on 2014-06-02
Changed in ubuntu-ui-toolkit:
status: New → Incomplete
Michał Sawicz (saviq) wrote :

My exact use case was a transparent button with just the icon (granted, could use an AbstractButton instead). I believe the Button already makes a choice to colourize an icon based on its colour - making transparent a special case there would just be an addition.

Otherwise, an explicit colour could be passed to the component to override the automation.

Daniela Ferrai (dferrai) on 2014-06-24
Changed in ubuntu-ux:
assignee: nobody → Jouni Helminen (jounihelminen)
John Lea (johnlea) on 2014-07-22
summary: - Button icons can't be colourized
+ [sdk] Button icons can't be colourized
Changed in ubuntu-ux:
importance: Undecided → Medium
status: New → Triaged
Changed in ubuntu-ui-toolkit:
status: Incomplete → New
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Incomplete → New
Zsombor Egri (zsombi) on 2014-10-01
Changed in ubuntu-ui-toolkit:
status: New → Triaged
Zoltan Balogh (bzoltan) on 2014-10-01
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Jouni Helminen (jounihelminen) wrote :

I think it should be possible to to override any default colorisation of the icon in a button

Changed in ubuntu-ux:
status: Triaged → Fix Committed
Zoltan Balogh (bzoltan) on 2014-11-17
no longer affects: ubuntu-ui-toolkit (Ubuntu)
Zoltan Balogh (bzoltan) on 2014-11-24
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Zoltan Balogh (bzoltan) on 2014-11-24
no longer affects: ubuntu-ui-toolkit
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers