[browser] There is no search in page option in webbrowser-app (like ctrl+F)
Bug #1312260 reported by
mexlinux
This bug affects 9 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Medium
|
Ugo Riboni | ||
Ubuntu UX |
Fix Released
|
Medium
|
James Mulholland | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Ugo Riboni |
Bug Description
Users will be able to find text in page (partial&exact match)
- Function will be available in the Action Drawer
--- --- --- --- ---
UX Comment:
Spec here
https:/
Related branches
lp:~uriboni/oxide/find-in-page
- Chris Coulson: Approve
-
Diff: 863 lines (+587/-1)15 files modifiedqt/core/api/oxideqfindcontroller.cc (+97/-0)
qt/core/api/oxideqfindcontroller.h (+71/-0)
qt/core/api/oxideqfindcontroller_p.h (+46/-0)
qt/core/browser/oxide_qt_web_view.cc (+16/-1)
qt/core/browser/oxide_qt_web_view.h (+7/-0)
qt/core/core.gyp (+9/-0)
qt/core/glue/oxide_qt_web_view_proxy.h (+11/-0)
qt/qmlplugin/oxide_qml_plugin.cc (+5/-0)
qt/quick/api/oxideqquickwebview.cc (+7/-0)
qt/quick/api/oxideqquickwebview_p.h (+10/-0)
qt/tests/qmltests/api/tst_WebView_findController.html (+13/-0)
qt/tests/qmltests/api/tst_WebView_findController.qml (+152/-0)
qt/tests/qmltests/api/tst_WebView_findControllerManyResults.html (+9/-0)
shared/browser/oxide_web_view.cc (+102/-0)
shared/browser/oxide_web_view.h (+32/-0)
lp:~uriboni/webbrowser-app/find-in-page
Rejected
for merging
into
lp:webbrowser-app
- Olivier Tilloy: Disapprove
- Riccardo Padovani (community): Needs Fixing
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ugo Riboni (community): Approve
-
Diff: 647 lines (+351/-51)9 files modifieddebian/control (+2/-2)
src/app/actions/FindInPage.qml (+27/-0)
src/app/webbrowser/AddressBar.qml (+63/-22)
src/app/webbrowser/Browser.qml (+23/-6)
src/app/webbrowser/Chrome.qml (+71/-21)
tests/autopilot/webbrowser_app/emulators/browser.py (+11/-0)
tests/autopilot/webbrowser_app/tests/http_server.py (+5/-0)
tests/autopilot/webbrowser_app/tests/test_findinpage.py (+134/-0)
tests/unittests/qml/tst_AddressBar.qml (+15/-0)
lp:~osomon/webbrowser-app/find-in-page
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Riccardo Padovani (community): Approve
- Ubuntu Phablet Team: Pending requested
-
Diff: 825 lines (+430/-59)11 files modifieddebian/control (+2/-2)
src/app/actions/FindInPage.qml (+27/-0)
src/app/webbrowser/AddressBar.qml (+76/-25)
src/app/webbrowser/Browser.qml (+49/-9)
src/app/webbrowser/Chrome.qml (+1/-0)
src/app/webbrowser/NavigationBar.qml (+74/-23)
tests/autopilot/webbrowser_app/emulators/browser.py (+11/-0)
tests/autopilot/webbrowser_app/tests/http_server.py (+11/-0)
tests/autopilot/webbrowser_app/tests/test_findinpage.py (+156/-0)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+8/-0)
tests/unittests/qml/tst_AddressBar.qml (+15/-0)
summary: |
- There is no search in page option in webbroser-app (like ctrl+F) + There is no search in page option in webbrowser-app (like ctrl+F) |
summary: |
- There is no search in page option in webbrowser-app (like ctrl+F) + [browser] There is no search in page option in webbrowser-app (like + ctrl+F) |
Changed in ubuntu-ux: | |
status: | Triaged → New |
Changed in webbrowser-app: | |
status: | Triaged → New |
importance: | Undecided → Low |
Changed in ubuntu-ux: | |
status: | New → Triaged |
description: | updated |
Changed in webbrowser-app: | |
status: | New → Confirmed |
status: | Confirmed → Triaged |
description: | updated |
Changed in ubuntu-ux: | |
status: | Triaged → Fix Committed |
tags: | added: design-gap |
tags: | added: usability |
Changed in oxide: | |
status: | Confirmed → In Progress |
Changed in webbrowser-app: | |
status: | Triaged → In Progress |
Changed in oxide: | |
milestone: | none → branch-1.8 |
status: | In Progress → Fix Released |
Changed in ubuntu-ux: | |
assignee: | Giorgio Venturi (giorgio-venturi) → James Mulholland (jamesjosephmulholland) |
Changed in webbrowser-app (Ubuntu): | |
status: | Confirmed → In Progress |
assignee: | nobody → Ugo Riboni (uriboni) |
importance: | Undecided → Medium |
Changed in webbrowser-app: | |
assignee: | Ugo Riboni (uriboni) → nobody |
status: | In Progress → Invalid |
no longer affects: | webbrowser-app |
description: | updated |
Changed in ubuntu-ux: | |
importance: | Low → Medium |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Note that there is currently no design specification for search in page, so we’ll need one.