[sdk] Reorder design pattern
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Music App |
Fix Released
|
Medium
|
Andrew Hayzen | ||
Ubuntu UX |
Fix Released
|
Medium
|
Unassigned |
Bug Description
I need clarification on the design pattern to implement reordering and make it compatible with the current swipeDelete in the UITK, the current two candidates are.
First
1) PressAndHold a list item, this enables reordering for *all* list items (a hint may appear or all the list items could wobble)
2) User can click and drag *any* list item to a new position
3) PressAndHold on *any* list item disables reordering
Second
1) PressAndHold a list item, this enables reordering for *that* list item (a hint may appear or all the list item could wobble)
2) User can click and drag *that* list item to the new position
3) On release or PressAndHold? disables reordering
Note, there will have to be a release between steps 1 and 2.
Related branches
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Andrew Hayzen: Needs Fixing
- Victor Thompson: Needs Fixing
-
Diff: 1318 lines (+681/-516)7 files modifiedMusicNowPlaying.qml (+100/-366)
common/Reorder.qml (+462/-0)
common/SongsSheet.qml (+104/-22)
common/SwipeDelete.qml (+0/-105)
music-app.qml (+0/-1)
tests/autopilot/music_app/emulators.py (+9/-5)
tests/autopilot/music_app/tests/test_music.py (+6/-17)
- Victor Thompson: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 2712 lines (+1031/-1103)25 files modifiedMusicNowPlaying.qml (+47/-396)
MusicPlaylists.qml (+30/-62)
MusicSearch.qml (+13/-20)
MusicTracks.qml (+13/-29)
MusicaddtoPlaylist.qml (+1/-0)
common/CMakeLists.txt (+1/-1)
common/Expander.qml (+0/-165)
common/ExpanderItems/AddToPlaylist.qml (+0/-60)
common/ExpanderItems/AddToQueue.qml (+0/-58)
common/ExpanderItems/CMakeLists.txt (+0/-4)
common/ExpanderItems/DeletePlaylist.qml (+0/-59)
common/ExpanderItems/EditPlaylist.qml (+0/-59)
common/ListItemActions/AddToPlaylist.qml (+34/-0)
common/ListItemActions/AddToQueue.qml (+31/-0)
common/ListItemActions/CMakeLists.txt (+4/-0)
common/ListItemActions/DeletePlaylist.qml (+29/-0)
common/ListItemActions/EditPlaylist.qml (+35/-0)
common/ListItemActions/Remove.qml (+30/-0)
common/ListItemWithActions.qml (+547/-0)
common/MusicRow.qml (+1/-2)
common/SongsPage.qml (+47/-38)
music-app.qml (+2/-4)
po/com.ubuntu.music.pot (+73/-67)
tests/autopilot/music_app/emulators.py (+39/-55)
tests/autopilot/music_app/tests/test_music.py (+54/-24)
Changed in music-app: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Andrew Hayzen (andrew-hayzen) |
summary: |
- Reorder design pattern + [sdk] Reorder design pattern |
Changed in ubuntu-ux: | |
assignee: | nobody → Jouni Helminen (jounihelminen) |
Changed in ubuntu-ux: | |
assignee: | Jouni Helminen (jounihelminen) → Giorgio Venturi (giorgio-venturi) |
status: | New → Triaged |
Changed in ubuntu-ux: | |
status: | Triaged → New |
importance: | Undecided → Medium |
Changed in ubuntu-ux: | |
status: | New → Triaged |
Changed in music-app: | |
status: | In Progress → Fix Released |
Changed in ubuntu-ux: | |
status: | Triaged → Fix Released |
As a note for testing purposes, lp:~andrew-hayzen/music-app/reorder-support-001 (assuming the following patch has been run on the UITK lp:~andrew-hayzen/ubuntu-ui-toolkit/fix-swipe-delete-001) currently implements the second candidate stated in the bug description (with a hint and wobble on step 1 and onRelease selected in step 3).