[Weather app] Use search box from SDK
Bug #1218917 reported by
Christina Li
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UX |
Fix Committed
|
Medium
|
Christina Li | ||
| Ubuntu Weather App |
Fix Released
|
Medium
|
Martin Borho | ||
Bug Description
Current situation:
In edit, when searching for cities, the status indicator (spinning) or an error message is displayed (eg no location found). However, these are covered by the OSK, and user misses these feedback.
Desired solution:
Status indication and error message should be displayed in view where t is not covered by the OSK
Design suggestion:
- Can we check if we are using the "search" component from the SDK for search input? (At the moment it looks like a text input field)
- When using the search box, on 'enter' the OSK should automatically be dismissed, then we can see the messages on screen.
- The message "Location not found" , needs to be in small-font (sdk)
Related branches
lp:~martin-borho/ubuntu-weather-app/searchinput
- Raúl Yeguas: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 549 lines (+412/-36)4 files modifiedcomponents/AddLocationSheet.qml (+115/-29)
resources/images/search.svg (+153/-0)
resources/images/search_item@8.svg (+105/-0)
tests/autopilot/ubuntu_weather_app/tests/test_locationmanager.py (+39/-7)
| Changed in ubuntu-ux: | |
| status: | New → Fix Committed |
| assignee: | nobody → Christina Li (christina-li) |
| importance: | Undecided → Medium |
Revision history for this message
| Martin Borho (martin-borho) wrote | #1 |
| description: | updated |
| Changed in ubuntu-weather-app: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Christina Li (christina-li) wrote | #3 |
| summary: |
- [Weather app] Edit loading status and error message is covered by OSK + [Weather app] Use search box from SDK |
| Changed in ubuntu-weather-app: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Martin Borho (martin-borho) |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #4 |
| Changed in ubuntu-weather-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-weather-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Is there a guideline by the design team, where and how to display a notification to the user? Or even better, a sdk-component to use?