[AddressBook] "back" toolbar incorrectly shows on top of "cancel/save" buttons
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Won't Fix
|
Critical
|
Olga Kemmet | ||
address-book-app |
Fix Released
|
Critical
|
Tiago Salem Herrmann | ||
address-book-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
17-sept-2013:
toolbar still appears when trying to dismiss OSK.
Please see screenshot attached, and please re-open this bug as it is not fixed.
-------
address-book-app 0.2+13.
When editing/creating a new contact, we correctly show the cancel/save panel above the keyboard. The problem is that you can mistakenly get the original toolbar (with back button) to appear on top of the cancel/save panel. This happens if you miss pressing the cancel button or start to swipe the keyboard down and then release it. The back toolbar should never appear if you are in edit/save mode.
Steps to reproduce:
1) edit a contact
2) press just below the cancel/save button but above the keyboard
or
2) swipe the keyboard down a little and then release it
Expected results:
- always have Cancel/Save panel visible and on top until you actually cancel or save
Actual results:
- the wrong toolbar is shown on top of the cancel/save
-------
Desired solution
- always have Cancel/Save panel visible and on top until you actually cancel or save
- when dismissing OSK by swiping down, the Cancel/Save should be attached to the OSK and swipe down at the same as it feels odd right now
Related branches
- Gustavo Pichorim Boiko (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 273 lines (+127/-33)8 files modifiedsrc/imports/ContactEdit/ContactDetailAddressesEditor.qml (+1/-1)
src/imports/ContactEdit/ContactDetailWithTypeEditor.qml (+8/-0)
src/imports/ContactEdit/ContactEditor.qml (+6/-0)
src/imports/ContactEdit/TextInputDetail.qml (+2/-0)
src/imports/ContactView/ContactView.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactDetailPickerPhoneNumberDelegate.qml (+58/-25)
src/imports/Ubuntu/Contacts/ContactListView.qml (+2/-0)
src/imports/Ubuntu/Contacts/ContactSimpleListView.qml (+49/-6)
Changed in address-book-app: | |
importance: | Undecided → Critical |
assignee: | nobody → Tiago Salem Herrmann (tiagosh) |
Changed in address-book-app: | |
status: | New → In Progress |
tags: | added: addressbk-aug-2013 |
Changed in address-book-app: | |
status: | Fix Committed → Fix Released |
Changed in address-book-app (Ubuntu): | |
status: | Confirmed → Fix Released |
Changed in ubuntu-ux: | |
status: | New → Fix Committed |
importance: | Undecided → Critical |
assignee: | nobody → Rachel Liu (rachelliu) |
Fix committed into lp:address-book-app at revision 56, scheduled for release in address-book-app, milestone ubuntu-13.07