[sdk]Switch theme button in UITK component gallery
Bug #1211382 reported by
Jouni Helminen
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Medium
|
Unassigned | ||
Ubuntu UX |
Fix Released
|
Undecided
|
Jouni Helminen | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
We have been doing a design review of the toolkit app and would like to add a toolbar to the components.
In the toolbar we would want:
an icon for "Switch theme" to switch between light/dark/gradient themes. This will help us review the designs of components using the different themes. Matthieu is adding a new switch icon to the icon theme, it will be called switch.svg. Should land within a day or two
Related branches
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/galleryTweaksPage
- PS Jenkins bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 68 lines (+53/-0)2 files modifiedexamples/ubuntu-ui-toolkit-gallery/Styles.qml (+48/-0)
examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml (+5/-0)
Superseded
for merging
into
lp:ubuntu-ui-toolkit
- Tim Peeters: Needs Resubmitting
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 374 lines (+87/-71)12 files modifiedCHANGES (+1/-1)
components.api (+7/-14)
examples/ubuntu-ui-toolkit-gallery/Tweaks.qml (+48/-0)
examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml (+5/-0)
modules/Ubuntu/Components/AnimatedItem.qml (+1/-38)
modules/Ubuntu/Components/ListItems/Base.qml (+1/-1)
modules/Ubuntu/Components/PageStack.qml (+1/-0)
modules/Ubuntu/Components/Pickers/DatePicker.qml (+4/-2)
modules/Ubuntu/Components/plugin/i18n.cpp (+6/-5)
modules/Ubuntu/Components/plugin/thumbnailgenerator.cpp (+6/-3)
modules/Ubuntu/Components/qmldir (+1/-2)
tests/qmlapicheck.py (+6/-5)
Changed in ubuntu-ui-toolkit: | |
assignee: | Zsombor Egri (zsombi) → Tim Peeters (tpeeters) |
summary: |
- Toolbar for components, with "Back" and "Switch theme" icons + Switch theme button in UITK component gallery |
tags: | added: theme uitk-gallery |
Changed in ubuntu-ui-toolkit: | |
importance: | High → Medium |
assignee: | Tim Peeters (tpeeters) → nobody |
description: | updated |
Changed in ubuntu-ui-toolkit: | |
status: | Incomplete → Confirmed |
Changed in ubuntu-ux: | |
status: | New → Fix Committed |
summary: |
- Switch theme button in UITK component gallery + [sdk]Switch theme button in UITK component gallery |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Fix Released |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I don't understand 1). If you have a PageStack, there will automatically be a back button in the toolbar to go back one step in the stack. Going back to the "mainview" (without pages on the stack?) does not make sense because that would be empty. You need a Page.
For 2) I assume you are referring to the UITK gallery app?