[Weather app] Manage location screens are implemented differently to visual spec

[Christina Li]

Manage location differs from Visual Designs. Please align.
-----------------------------------------------------------------

1. Tool bar should say 'Edit' instead of 'Add' for location
2. The experience should be implemented as spec, see link...under 'Manage locations'
http://design.canonical.com/2013/03/app-patterns-applied-weather-key-journeys/

[Christina Li (christina-li)]

Attached is the patterns to be used for Manage Location

[Martin Borho (martin-borho)]

Hi Christina,

thanks for the pattern!

Problem is: you can't open a Page from a Sheet without closing the Sheet and/or pushing a Page on top of the MainPage. Therefore opening a Page from a Sheet would not result in a logical page tree. Part of this is, that the PageStack should always be bound to the MainWindow. It's not possible to create a PageStack inside of a Sheet compoment.

So I think, the pattern should be reconsidered. Perhaps adjusting the design of the current LocationManagerPage would be the better way.

Cheers
Martin

[Christina Li (christina-li)]

Hi Martin,
Thanks for the feedback.

Based on this, let's remove the page stack pattern and use the sheet pattern throughout the edit location.
When a user is searching for a list of cities- the 'cancel' button will take the user back to the main page.
When a user is searching for a list of cities by tapping to adding a city will automatically take the user back to the main page (without the need to hit done).

let me know if you got other questions.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-weather-app at revision 71, scheduled for release in ubuntu-weather-app, milestone alpha-1

[Christina Li (christina-li)]

Hi, re-opening this bug as Manage location isn't implemented according to visual design spec yet.

[Martin Borho (martin-borho)]

This relates to the gradient or to https://bugs.launchpad.net/ubuntu-weather-app/+bug/1195243 ?

[Christina Li (christina-li)]

Hi Martin,
Both- Michal had a look at the current visual implementation yesterday and he has provided a 'Add a city' screen visual design which we need to look at implementing.

[Martin Borho (martin-borho)]

Okay, nonetheless we need an updated Sheet component and the visiual design assets before we can move on with implementing the visual design in the "Add a city" sheet.

Cheers
Martin

[David Planella (dpm)]

Which elements need still fixing on this bug? It might be worth marking this one as Fix Released and filing new bugs for each part that still needs design or SDK implementation, as otherwise it's difficult to track the work required.