[Calculator app] [Visual design] Button padding/spacing inconsistent
Bug #1156523 reported by
Alan Pope πΊπ§π± π¦
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Calculator App |
Fix Released
|
Medium
|
Dalius | ||
Ubuntu UX |
Fix Released
|
Medium
|
Christina Li |
Bug Description
The button spacing in qmlscene on the desktop is fine, with the padding between C, 7, 4, 1, 0 and the left edge, and X, -, + and = and the right edge being fine. However on the mobile device the padding is no longer there, and the buttons are hard up against the edge of the device screen. The buttons should line up in the same way on device as in qmlscene on the desktop.
Are we using grid-units to place the buttons correctly?
Related branches
lp:~dalius-sandbox/ubuntu-calculator-app/adaptive-keyboard-size
- Riccardo Ferrazzo (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 219 lines (+38/-39)3 files modifiedSimple/CalcKeyboard.qml (+34/-31)
Simple/KeyboardButton.qml (+4/-4)
ubuntu-calculator-app.qml (+0/-4)
Changed in ubuntu-calculator-app: | |
assignee: | nobody → Dalius Dobravolskas (dalius-sandbox) |
milestone: | none → alpha-1 |
status: | Incomplete → Confirmed |
Changed in ubuntu-calculator-app: | |
status: | Confirmed → In Progress |
Changed in ubuntu-ux: | |
status: | New → In Progress |
importance: | Undecided → High |
importance: | High → Medium |
summary: |
- Button padding/spacing inconsistent + [Calculator app] Button padding/spacing inconsistent |
summary: |
- [Calculator app] Button padding/spacing inconsistent + [Calculator app] [Visual design] Button padding/spacing inconsistent |
Changed in ubuntu-ux: | |
assignee: | nobody → Christina Li (christina-li) |
Changed in ubuntu-calculator-app: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ux: | |
status: | In Progress → Triaged |
status: | Triaged → Fix Released |
To post a comment you must log in.
We are using grid units correctly. However we might have made wrong assumption about device size.