[sdk] Dialog doesn't take the contents size into consideration

Bug #1376763 reported by Jonas G. Drange on 2014-10-02
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Canonical System Image
High
Zoltan Balogh
Ubuntu UI Toolkit
Fix Committed
Critical
Christian Dywan
Ubuntu UX
High
Olga Kemmet
ubuntu-system-settings (Ubuntu)
Undecided
Christian Dywan
ubuntu-system-settings (Ubuntu RTM)
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu)
Vivid
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)
Critical
Christian Dywan

Bug Description

A dialog doesn't scroll if the text (as in the code example) or its contents exceeds the viewport size.

This can be reproduced in e.g. ubuntu-system-settings:
(Make sure you're running the very latest from proposed or a USS from October 2014 – debs[1]).

1. Open Ubuntu System Settings
2. Go to the Wi-Fi panel
3. Click "Connect to hidden network…"
4. Choose any security scheme other that "None"
4. Resize the viewport/use landscape on a device

What I expect to happen:
I can scroll inside the Dialog to access all fields and buttons

What happened instead:
The content not visible becomes inaccessible

Example code:
http://paste.ubuntu.com/8479468/

[1] https://launchpad.net/ubuntu-system-settings/+packages

UX Solution:
Make sure content can scroll vertically if exceeding the maximum height of the dialog

Related branches

description: updated
Zsombor Egri (zsombi) wrote :

Jonas, there is a recent fix on dialog content resizing, could you please check whether that fixes this bug as well? The fix is at the bug #1337556

Changed in ubuntu-ui-toolkit:
status: New → Triaged
Changed in ubuntu-ui-toolkit:
assignee: nobody → Christian Dywan (kalikiana)
Christian Dywan (kalikiana) wrote :

Bug 1337556 is a different issue, it doesn't address the problem of the dialog extending beyond the screen size.

This issue will probably be resolved by putting the dialog contents into a flickable so it can scroll.

Changed in ubuntu-ui-toolkit:
importance: Undecided → Critical
status: Triaged → In Progress
Tim Peeters (tpeeters) wrote :

Question for design, in this use case, is the dialog what we want to use? Another option is to push a new Page on the PageStack.

On Thursday, 2 October 2014, Zsombor Egri <email address hidden>
wrote:

> Jonas, there is a recent fix on dialog content resizing, could you
> please check whether that fixes this bug as well? The fix is at the bug
> #1337556
>

It helps. But it does not address the issue in full.

Jonas G. Drange (jonas-drange) wrote :

On Thursday, 2 October 2014, Tim Peeters <email address hidden> wrote:

> Question for design, in this use case, is the dialog what we want to
> use? Another option is to push a new Page on the PageStack.
>
I should not answer this, but I'd like to speculate. :)

If you put content in a Dialog, you can force the user to make an action
before continuing. The page stack pattern is associated with a back button
which may not fit the narrative.

"You need to enter a password [complete] [cancel action]"

An action to go back is a bit unclear in this case.

It is unlikely, but possible for a dialog to exceed the available height. The wi-fi is a good example where it could happen if there's a large amount of networks.

In general we should advise avoid against dialogs for large amount of information, but sometimes it might be necessary.

Changed in ubuntu-ux:
assignee: nobody → Giorgio Venturi (giorgio-venturi)
importance: Undecided → High
tags: added: ota-1
description: updated
Changed in ubuntu-ux:
status: New → Fix Committed
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → In Progress
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Zoltan Balogh (bzoltan) on 2014-10-13
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → Critical
status: In Progress → Fix Committed
Zoltan Balogh (bzoltan) on 2014-10-13
Changed in ubuntu-ui-toolkit:
milestone: none → 10.24
Changed in ubuntu-ui-toolkit (Ubuntu):
milestone: none → ubuntu-14.10
Omer Akram (om26er) wrote :

I am testing silo 13 and this bug is not fixed. I showed that to Christian as well.

Changed in ubuntu-system-settings (Ubuntu):
status: New → Confirmed
Christian Dywan (kalikiana) wrote :

The fix in the UITK is being compromised by the hack in the Wifi plugin in the System Settings to work-around OSK anchoring problems. I attached a branch that demonstrates that the dialog scrolls fine. As long as the security selector is expanded the password entry is inaccessible.

Christian Dywan (kalikiana) wrote :

The only remaining issue is that the password field may need scrolling to become visible; I'm not sure where that should be addressed but it's not preventing the user from filling in the password.

Changed in ubuntu-system-settings (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Christian Dywan (kalikiana)
Tim Peeters (tpeeters) on 2014-10-24
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+15.04.20141112.1-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.04.20141112.1-0ubuntu1) vivid; urgency=low

  [ Sebastien Bacher ]
  * Update the translations template during the build (LP: #1389786)

  [ jonas-drange ]
  * [cellular][phone] titles now using SettingsItemTitle (LP: #1389767)
  * [wifi] fix multiple issues in the "Connect to other network" dialog
    (LP: #1387656)

  [ Andrea Cimitan ]
  * Delay password set/confirm screens after entering the 4th digit,
    fixing 1390557 (LP: #1390557)

  [ CI bot ]
  * Resync trunk

  [ Ken VanDine ]
  * Specify DaemonVersion for upower to support upower 0.99 on vivid
    (LP: #1390629)
  * [battery] don't control wifi state with libnm, use the
    QDBusActionGroup from indicator-network (LP: #1391940)

  [ Christian Dywan ]
  * Remove the dialog internals resizing hack (LP: #1376763)
 -- Ubuntu daily release <email address hidden> Wed, 12 Nov 2014 19:27:21 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
Bill Filler (bfiller) on 2014-12-04
tags: added: rtm14
Changed in canonical-devices-system-image:
status: New → In Progress
summary: - Dialog doesn't take the contents size into consideration
+ [sdk] Dialog doesn't take the contents size into consideration
Changed in ubuntu-ux:
assignee: Giorgio Venturi (giorgio-venturi) → Olga Kemmet (olga-kemmet)
Changed in canonical-devices-system-image:
assignee: nobody → Zoltan Balogh (bzoltan)
importance: Undecided → High
milestone: none → ww46-2015
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Changed in canonical-devices-system-image:
milestone: ww46-2015 → ww02-2016
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit/staging at revision 1726, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: Fix Released → Fix Committed
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Zoltan Balogh (bzoltan) on 2015-12-05
no longer affects: ubuntu-ui-toolkit (Ubuntu)
Zoltan Balogh (bzoltan) on 2015-12-07
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: New → Fix Committed
assignee: nobody → Christian Dywan (kalikiana)
importance: Undecided → Critical
Łukasz Zemczak (sil2100) wrote :
Download full text (6.8 KiB)

This bug was fixed in the package ubuntu-ui-toolkit 1.3.1742+15.04.20151209-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-ui-toolkit (1.3.1742+15.04.20151209-0ubuntu1) vivid; urgency=medium

  [ Zoltán Balogh ]
  * Enable building the UITK tests in any case.
  * Remove Q_Q(UCStyledItemBase) because of unused variable warning.
  * Resolve Trusty specific compiler issue not resolving QPointer data on
    connections.
  * Use only the object name when selecting sections and labels in tests.

  [Zsombor Egri ]
  * Update BottomEdge with UI/UX agreed during the sprint. Fixes LP: #1368811.
  * BottomEdge component. Fixes LP: #1368811.
  * Remove build failure on Xenial caused by deprecated Qt functions.
  * Fix BottomEdgeHint consumes activeFocusOnPress handling. Fixes LP: #1517777
  * Migrate DirectionalDragArea from Unity8, named as SwipeArea. Original code
    (from lp:unity8) by: Daniel d'Andrada <email address hidden>.
  * Delete QQuickView when the application quits. Fixing segfault caused by the
    dangling objects in GestireDetector.
  * BottomEdgeHint API changes, deprecating state property, introducing locked
    property to drive visuals lock and click handling.
  * Fixing CheckBox and Switch getting checked property altered after clicked()
    signal is emitted. Fixes LP: #1510919.
  * Add ListItem.swipeEnabled property to block swiping when overlay MouseArea
    is used to drag content. Fixes swiping when leading/trailing actions list
    is empty. Fixes LP: #1500409, LP: #1500416.
  * Follow the new design in BottomEdgeHint.
  * Provide import version information for StyledItem and remove theme.version
    obsolete property.
  * Use QQuickItemChangeListener to listen parent changes, skipping the meta
    object model. Convert UCThemingExtension into a Q_INTERFACE so object_cast<>
    can work with it saving the need to memorise on an item whether it is an
    extended item or not.
  * Set mouseAttached to false to revert regression in UITK gallery.
  * Remove BottomEdgeHint from UITK gallery's MainPage.qml which occludes with
    the bottom-up dragging of the ListView.

  [ Benjamin Zeller ]
  * Avoid unnecessary updates for i18n strings.
  * "MathUtils.clamp, min value should not be bigger than the max value".
    Fixes LP: #1520557.
  * Move MathUtils to Cpp.

  [ Loïc Molinari ]
  * UbuntuShape - Fixed deprecation logging issues.
  * This fix prevents logging a deprecation warning for "image", "color" and
    "gradientColor" properties when the import version is less than 1.3. The
    logging of properties used internally (through the old image wrapper) have
    been removed too since the user might not even have used them.
    Fixes LP: #1519414.

  [ Christian Dywan ]
  * Enable gallery target in qmake.
  * Don't set activeFocusOnPress on TextField but on child only.
    Fixes LP: #1486274, LP: #1513897.
  * Make runtest.sh work out of the box again.
  * Explicitly handle keyboard anchoring in dialog foreground.
    Fixes LP: #1376763.
  * Remove GestureDetector in favor of SwipeArea in BottomEdgeHint. Also make
    possible to assign Action to the ...

Read more...

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: Fix Committed → Fix Released
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers