Alarm model is updated after every change causing all the listview items to be repainted
Bug #1359112 reported by
Nekhelesh Ramananthan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UI Toolkit |
Fix Released
|
High
|
Zsombor Egri | ||
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Vivid |
New
|
Undecided
|
Unassigned | ||
Bug Description
At the moment any change made to an alarm results in the entire alarm model being updated. This in turn causes the listview to be repainted which can cause the UI elements to reinitialize causing a flicker. In the clock app for instance, for every alarm operation like enabling/disabling an alarm, creating a new alarm etc, results in the listview to be repainted. This is expensive operation and also since the UI elements are repainted it causes some flicker.
Related branches
lp:~zsombi/ubuntu-ui-toolkit/20-alarm-model-update
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
- Nekhelesh Ramananthan: Pending requested
-
Diff: 332 lines (+141/-13)9 files modifiedmodules/Ubuntu/Components/plugin/adapters/alarmsadapter_organizer.cpp (+46/-1)
modules/Ubuntu/Components/plugin/adapters/alarmsadapter_p.h (+1/-0)
modules/Ubuntu/Components/plugin/alarmmanager_p.cpp (+1/-1)
modules/Ubuntu/Components/plugin/alarmmanager_p.h (+20/-1)
modules/Ubuntu/Components/plugin/alarmmanager_p_p.h (+1/-1)
modules/Ubuntu/Components/plugin/ucalarmmodel.cpp (+29/-1)
modules/Ubuntu/Components/plugin/ucalarmmodel.h (+1/-0)
tests/unit/tst_alarms/tst_alarms.cpp (+2/-2)
tests/unit_x11/tst_components/tst_alarms.qml (+40/-6)
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Confirmed |
| assignee: | nobody → Zsombor Egri (zsombi) |
| importance: | Undecided → Medium |
| tags: | added: rtm14 |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Medium → Critical |
| importance: | Critical → High |
| Changed in ubuntu-ui-toolkit: | |
| status: | Confirmed → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #1 |
| Changed in ubuntu-ui-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-ui-toolkit: | |
| milestone: | none → 10.24 |
Revision history for this message
| Zsombor Egri (zsombi) wrote | #2 |
| Changed in ubuntu-ui-toolkit: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-ui-toolkit/staging at revision 1209, scheduled for release in ubuntu-ui-toolkit, milestone Unknown