Black squares shown in header actions if no icon set

Bug #1354811 reported by David Planella on 2014-08-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
High
Christian Dywan
ubuntu-ui-toolkit (Ubuntu)
Undecided
Unassigned
Vivid
Undecided
Unassigned

Bug Description

See the attached screenshot.

- Expected: no icon shown for the action if the icon has not been set
- Actual: black square is shown to represent an empty icon

It corresponds to header actions for the following code snippet:

            head.actions: [
                Action {
                    text: i18n.tr("Settings")
                    iconName: "settings"
                    onTriggered: pageStack.push(settingsPage)
                },
                Action {
                    objectName: "hidepanelaction"
                    iconName: "edit-clear"
                    text: i18n.tr("Hide all key panels")
                    onTriggered: pgTerm.showExtraPanel(0)
                },
                Action {
                    objectName: "controlkeysaction"
                    text: i18n.tr("Show control keys panel")
                    onTriggered: pgTerm.showExtraPanel(1)
                },
                Action {
                    objectName: "functionkeysaction"
                    text: i18n.tr("Show function keys panel")
                    onTriggered: pgTerm.showExtraPanel(2)
                },
                Action {
                    objectName: "textkeysaction"
                    text: i18n.tr("Show arrow keys panel")
                    onTriggered: pgTerm.showExtraPanel(3)
                }
            ]
        }

Related branches

David Planella (dpm) wrote :
tags: added: avengers
Tim Peeters (tpeeters) on 2014-08-26
Changed in ubuntu-ui-toolkit:
assignee: nobody → Christian Dywan (kalikiana)
status: New → In Progress
importance: Undecided → High
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit/staging at revision 1217, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1227+14.10.20140904-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1227+14.10.20140904-0ubuntu1) utopic; urgency=medium

  [ Zsombor Egri ]
  * Thin divider adjustments.
  * Dialog title is wrapped into maximum two lines, then elides.
    Fixes LP: #1354376

  [Florian Boucault ]
  * Page: only compile and load ToolbarItems if strictly necessary.
  * Fixed usage of images across the board:
    - Made images as small as possible:
      - ListItemDivider6px.png
      - bubble_shadow*.png
      - header_overflow_dropshadow.png
  * Removed direct references to @GU in OptionSelector
  * Button's stroke_button.png now loaded only when necessary,
    asynchronously and not cached.
  * Removed unused ListItemDivider24px.png.

  [ Ugo Riboni ]
  * Disable the mousearea on top of the content when using the new
    header, as it is useless and it interferes with other input
    elements in the content area. Fixes LP: #1358327

  [ Christian Dywan ]
  * Update caret visuals and position.
  * Use iconSource for actions in the overflow panel.
    Fixes LP: #1354036, LP: #1354811
  * Replace off white with pure white. Fixes LP: #1354077
  * Push Python3 dist-packages to Phone in addition to Python2.7
  * Fix wrong sheet labels and pick up dtr strings. Fixes LP: #1354485

  [ Tim Peeters ]
  * Fix header test

  [ CI bot ]
  * Resync trunk

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Thu, 04 Sep 2014 07:57:06 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Zoltan Balogh (bzoltan) on 2014-10-01
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers