API break: ItemSelector.expanded changed to read-only

[Iain Lane]

system-settings makes use of ListItem.ItemSelector.expanded in a few places. In

  https://code.launchpad.net/~nicolas-doffay/ubuntu-ui-toolkit/selectors-multi-selection

this was changed to a read-only property and 'alwaysExpanded' provided to covers some of the use-cases for setting expanded before.

This is an API break which IMO shouldn't have happened. Could it be fixed?

It breaks a lot of ubuntu-system-settings. For example:

laney@raleigh> system-settings cellular
QInotifyFileSystemWatcherEngine::addPaths: inotify_add_watch failed: No space left on device
unity::action::ActionManager::ActionManager(QObject*):
 Could not determine application identifier. HUD will not work properly.
 Provide your application identifier in $APP_ID environment variable.
UCUriHandler: Empty "APP_ID" environment variable, ignoring.
file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/PageWrapperUtils.js:42: Error: Error while loading page: file:///usr/share/ubuntu/settings/system/qml-plugins/cellular/PageComponent.qml:65 Invalid property assignment: "expanded" is a read-only property

file:///usr/lib/x86_64-linux-gnu/qt5/qml/Ubuntu/Components/ListItems/SingleControl.qml:59: Unable to assign [undefined] to bool

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Tim Peeters (tpeeters)]

Nic, please make a small MR that fixes the issues.

Don't include it in your large upcoming MR because that one will take too long to review, and it is clearer if separate bugfixes are in separate MRs.

[Tim Peeters (tpeeters)]

If we still want to improve the API, we need to deprecate properties first and keep them around for a while. As we discussed before that is difficult in this case, but let's just get this bug fixed now and we can discuss afterwards.

[Dave Morley (davmor2)]

I believe this affects Setting time/date and also the game selector on solitare games click app.

[Dave Morley (davmor2)]

This is still in place and affects image 14 on Maguro

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:ubuntu-ui-toolkit at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.46+14.04.20131108.3-0ubuntu1

---------------
ubuntu-ui-toolkit (0.1.46+14.04.20131108.3-0ubuntu1) trusty; urgency=low

  [ Leo Arias ]
  * Add a check for the autopilot version on the emulator init. (LP:
    #1248570)
  * Ensure the toolbar is opened when clicking a toolbar in autopilot
    tests. (LP: #1248487)

  [ Nicolas d'Offay ]
  * Reverted API break on the selectors. (LP: #1248646)

  [ tpeeters ]
  * Ensure the toolbar is opened when clicking a toolbar in autopilot
    tests. (LP: #1248487)
  * before fixing the actual bug, the test gives me these errors: QWARN
    : tst_MainView::testNoWarnings_bug186065()
    unity::action::ActionManager::ActionManager(QObject*): Could not
    determine application identifier. HUD will not work properly.
    Provide your application identifier in $APP_ID environment variable.
    QWARN : tst_MainView::testNoWarnings_bug186065()
    file:///home/tim/dev/ubuntu-ui-
    toolkit/fix1244660/modules/Ubuntu/Components/MainView.qml:257:
    TypeError: Cannot call method 'hasOwnProperty' of null **
    (process:27191): CRITICAL **: Unable to get session bus: Operation
    was cancelled QWARN : tst_MainView::testNoWarnings_bug186065() Don't
    know how to handle 'QList<QQmlError>', use qRegisterMetaType to
    register it. PASS : tst_MainView::testNoWarnings_bug186065() PASS :
    tst_MainView::cleanupTestCase() Totals: 8 passed, 0 failed, 0
    skipped ********* Finished testing of tst_MainView ********* I get
    the same when I execute unit_x11/tst_orientation/tst_orientation:
    QWARN : tst_OrientationTest::test_defaults() Don't know how to
    handle 'QList<QQmlError>', use qRegisterMetaType to register it.
    PASS : tst_OrientationTest::test_defaults() Should I execute the
    tests in a different way?. (LP: #186065, #1244660)

  [ Robert Bruce Park ]
  * (no message)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 828
 -- Ubuntu daily release <email address hidden> Fri, 08 Nov 2013 22:02:57 +0000