We shouldn't rely on the order of the buttons on the tab bar
Bug #1233393 reported by
Leo Arias
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UI Toolkit |
Fix Released
|
Undecided
|
Leo Arias | ||
Bug Description
On the autopilot emulator, we switch to the next tab based on the index of the button on the qml tree. But now the order of the buttons changed, so we can't rely on it. We need to use the buttonIndex property instead.
Related branches
lp:~elopio/ubuntu-ui-toolkit/fix_tab_switch
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 116 lines (+36/-4)1 file modifiedtests/autopilot/ubuntuuitoolkit/emulators.py (+36/-4)
lp:~zsombi/ubuntu-ui-toolkit/tab-index
- PS Jenkins bot: Approve (continuous-integration)
- Zoltan Balogh: Approve
-
Diff: 226 lines (+73/-5)7 files modifiedCHANGES (+1/-0)
components.api (+2/-0)
modules/Ubuntu/Components/Tab.qml (+16/-0)
modules/Ubuntu/Components/Tabs.qml (+5/-1)
tests/autopilot/ubuntuuitoolkit/emulators.py (+36/-4)
tests/unit/tst_components/tst_tab.qml (+4/-0)
tests/unit/tst_components/tst_tabs.qml (+9/-0)
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Confirmed |
| assignee: | nobody → Leo Arias (elopio) |
| Changed in ubuntu-ui-toolkit: | |
| status: | Confirmed → Fix Committed |
| Changed in ubuntu-ui-toolkit: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
