[OptionSelector] needs a "entry has been clicked" signal
Bug #1218250 reported by
Sebastien Bacher
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Undecided
|
Nicolas d'Offay | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Current there is only has onSelectedIndex
- there is no way to tell appart code selection and user selection (e.g if you set the index, for a component, when loading, you get the callback triggered)
- we want some actions to only happen on user action (e.g in the "ringtone selection" screen we want the preview to happen only when user click, not when the index is updated due to a config change)
- the design require for the actions to happen on click sometime even when the selection doesn't change (e.g in the "ringtone selection" case, clicking on the currently selected entry should preview the sound again)
Thanks for considering!
Related branches
lp:~nicolas-doffay/ubuntu-ui-toolkit/list-item-option-selector
- PS Jenkins bot: Approve (continuous-integration)
- Zoltan Balogh: Approve
-
Diff: 1255 lines (+719/-177)17 files modifiedCHANGES (+8/-0)
components.api (+6/-5)
examples/ubuntu-ui-toolkit-gallery/ListItems.qml (+51/-2)
examples/ubuntu-ui-toolkit-gallery/OptionSelectors.qml (+5/-9)
modules/Ubuntu/Components/ListItems/ItemSelector.qml (+211/-0)
modules/Ubuntu/Components/ListItems/MultiValue.qml (+0/-6)
modules/Ubuntu/Components/ListItems/ValueSelector.qml (+2/-0)
modules/Ubuntu/Components/ListItems/qmldir (+1/-0)
modules/Ubuntu/Components/OptionSelector.qml (+34/-21)
modules/Ubuntu/Components/OptionSelectorDelegate.qml (+72/-27)
modules/Ubuntu/Components/Themes/Ambiance/ListItemOptionSelectorStyle.qml (+27/-0)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+1/-0)
modules/Ubuntu/Components/Themes/SuruDark/ListItemOptionSelectorStyle.qml (+23/-0)
modules/Ubuntu/Components/Themes/SuruGradient/ListItemOptionSelectorStyle.qml (+27/-0)
tests/unit/tst_components/tst_optionselector.qml (+0/-107)
tests/unit_x11/tst_components/tst_listitems_itemselector.qml (+126/-0)
tests/unit_x11/tst_components/tst_optionselector.qml (+125/-0)
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Nicolas d'Offay (nicolas-doffay) |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-ui-toolkit at revision 735, scheduled for release in ubuntu-ui-toolkit, milestone Unknown