[ListItem.SingleControl] Does not respect the default inner margins

[Sebastien Bacher]

Some of system settings design use lists with buttons in the middle, those should use the same spacing as other list items.

The margins for ListItem.Standard text seems to be units.gu(2), which leads to code like that one to get the right result:

" ListItem.SingleControl {
            control: Button {
                anchors {
                    leftMargin: units.gu(2)
                    rightMargin: units.gu(2)
                    topMargin: units.gu(1)
                    bottomMargin: units.gu(1)
                    fill: parent
                }
                text: "Some button to click"
            }
        }"

It's a bit tedious to have to specify all the margins like that, it also feels wrong because it would break if the toolkit change ... is there a better way to do that?

[Sebastien Bacher (seb128)]

That screenshot show a list with different spacing, mpt said the correct one is 2 gu spaces horizontal and 1 gu vertical...

[Florian Boucault (fboucault)]

Try:

ListItem.Base {
    Button {
        anchors {
            verticalCenter: parent.verticalCenter
            right: parent.right
            left: parent.left
        }
    }
}

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.1+13.10.20130628-0ubuntu1

---------------
ubuntu-system-settings (0.1+13.10.20130628-0ubuntu1) saucy; urgency=low

  [ Sebastien Bacher ]
  * Use Base items for buttons, instead of SingleControl ones (until bug
    #1194844 is fixed in the ui toolkit). That should give us correct
    margins for those items. (LP: #1194844)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 73
 -- Ubuntu daily release <email address hidden> Fri, 28 Jun 2013 07:01:06 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings-online-accounts - 0.2~+13.10.20130628-0ubuntu1

---------------
ubuntu-system-settings-online-accounts (0.2~+13.10.20130628-0ubuntu1) saucy; urgency=low

  [ Ken VanDine ]
  * Don't include the example provider and plugin in the installed
    package .

  [ Sebastien Bacher ]
  * Use Base items for buttons, instead of SingleControl ones (until bug
    #1194844 is fixed in the ui toolkit). That should give us correct
    margins for those items. Use the same spacing for the labels. (LP:
    #1194844)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 23
 -- Ubuntu daily release <email address hidden> Fri, 28 Jun 2013 07:01:01 +0000

[Zsombor Egri (zsombi)]

This will be handled by the new ListItemLayout component.

[Zsombor Egri (zsombi)]

We decided that we will not make any common layouts for the ListItems. Every application will have to create their layouts or use some common components module to define layouts if needed, depending on the performance requirements.