Unable to hide toolbar with recent toolbar API change
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
High
|
Tim Peeters | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
With the change recent Toolbar API change (rev 550) to use ToolbarButton and ToolbarItems to manage a toolbar's buttons, actions etc, it is not possible to hide the toolbar. For instance here is a code sample which has a simple toolbarButton. OnTriggering it should hide the toolbar. However it does nothing at the moment.
This is a regression since bzr 550.
tools: ToolbarItems {
id: toolbarClock
id: addCity
action: Action {
}
}
}
}
Related branches
- Zsombor Egri: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 101 lines (+30/-8)3 files modifieddemos/MyCustomPage.qml (+3/-1)
modules/Ubuntu/Components/Toolbar.qml (+6/-1)
modules/Ubuntu/Components/ToolbarActions.qml (+21/-6)
- Cris Dywan: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 50 lines (+18/-1)2 files modifiedmodules/Ubuntu/Components/Toolbar.qml (+10/-1)
tests/unit/tst_components/tst_toolbar.qml (+8/-0)
description: | updated |
summary: |
- Unable to hide toolbar buttons with recent API change + Unable to hide toolbar with recent toolbar API change |
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Tim Peeters (tpeeters) |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
Nekhelesh, thanks for reporting the bug. Could you in the future paste the contents of a full working qml file in bug reports that I can run directly to test? That saves me a little bit of time :)
I'm looking into this bug now.