Unable to hide toolbar with recent toolbar API change

Bug #1192673 reported by Nekhelesh Ramananthan
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
High
Tim Peeters
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

With the change recent Toolbar API change (rev 550) to use ToolbarButton and ToolbarItems to manage a toolbar's buttons, actions etc, it is not possible to hide the toolbar. For instance here is a code sample which has a simple toolbarButton. OnTriggering it should hide the toolbar. However it does nothing at the moment.

This is a regression since bzr 550.

tools: ToolbarItems {
        id: toolbarClock

        ToolbarButton {
            id: addCity
            action: Action {
                iconSource: Qt.resolvedUrl("../images/add_icon.png")
                text: i18n.tr("Add City")
                onTriggered: {
                    clockPage.state = "ADDCITY";
                    toolbarClock.opened = false;
                }
            }
        }
}

Related branches

description: updated
summary: - Unable to hide toolbar buttons with recent API change
+ Unable to hide toolbar with recent toolbar API change
Changed in ubuntu-ui-toolkit:
assignee: nobody → Tim Peeters (tpeeters)
importance: Undecided → High
Revision history for this message
Tim Peeters (tpeeters) wrote :

Nekhelesh, thanks for reporting the bug. Could you in the future paste the contents of a full working qml file in bug reports that I can run directly to test? That saves me a little bit of time :)

I'm looking into this bug now.

Changed in ubuntu-ui-toolkit:
status: New → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 0.1.46+13.10.20130718-0ubuntu1

---------------
ubuntu-ui-toolkit (0.1.46+13.10.20130718-0ubuntu1) saucy; urgency=low

  [ Kaleo ]
  * Popover: added manual test program.
  * Popover simplifications: - simplified pointer positioning by only
    computing the position of the tip; it's up to the pointer to
    rotate/translate adequately. - fixed implementation of
    Popover.callerMargin and set default value to 0. - removed unused
    parameter 'pointerMargin' from InternalPopupUtils.CallerPositioning.

  [ tpeeters ]
  * Fix bug where toolbarActions.opened was not properly updated when
    the user swipes to show/hide the toolbar. (LP: #1192673)
  * Improve code examples in documentation.
  * Use UnityActions to make Actions available to HUD: - Action now
    inherits UnityActions.Action - Added "actions" property to MainView
    to contain global actions that are available in HUD as long as the
    app is running. - Added "actions" property to Page to contain local
    actions that are available in HUD when the Page is active. (LP:
    #1187869)

  [ Renato Araujo Oliveira Filho ]
  * Make sure that the keyboard does not obscure the contents of main
    window. (LP: #1131249)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 633
 -- Ubuntu daily release <email address hidden> Thu, 18 Jul 2013 06:07:54 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.