[Theming] custom styling objects which are owned by other styled items should be detached from their previous owners
Bug #1168006 reported by
Zsombor Egri
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Critical
|
Zsombor Egri | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Raring |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
Given the example:
Item {
id: root
ItemStyle.
Item {
id: internal
}
}
style and delegate (styling objects) ownership is transfered from "root" object to "internal", however it is not detached from "root".
Related branches
lp:~zsombi/ubuntu-ui-toolkit/fix-detach-style-objects
- PS Jenkins bot: Approve (continuous-integration)
- Florian Boucault: Pending requested
-
Diff: 629 lines (+339/-46)15 files modifiedmodules/Ubuntu/Components/plugin/itemstyleattached.cpp (+80/-39)
modules/Ubuntu/Components/plugin/itemstyleattached_p.h (+1/-1)
modules/Ubuntu/Components/plugin/ucstyle.cpp (+10/-1)
modules/Ubuntu/Components/plugin/ucstyle.h (+4/-0)
tests/unit/tst_theme_engine/CustomStyles.qml (+44/-0)
tests/unit/tst_theme_engine/tst_theme_engine.pro (+2/-1)
tests/unit/tst_theme_engine/tst_theme_enginetest.cpp (+31/-0)
tests/unit/tst_theme_engine_style/CustomDelegateComponent.qml (+30/-0)
tests/unit/tst_theme_engine_style/CustomDelegateObject.qml (+26/-0)
tests/unit/tst_theme_engine_style/CustomStyleObject.qml (+26/-0)
tests/unit/tst_theme_engine_style/StyledItem.qml (+22/-0)
tests/unit/tst_theme_engine_style/tst_theme_engine_style.pro (+5/-1)
tests/unit/tst_theme_engine_style/tst_theme_engine_styletest.cpp (+56/-1)
themes/Ambiance/qmltheme/HeaderDelegate.qml (+1/-1)
themes/Ambiance/qmltheme/NewTabsDelegate.qml (+1/-1)
summary: |
- [Theming] custom properties which are owned by other styled items should - be detached from their previous owners + [Theming] custom styling objects which are owned by other styled items + should be detached from their previous owners |
Changed in ubuntu-ui-toolkit: | |
status: | Confirmed → In Progress |
importance: | Medium → Critical |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Please define what 'detach' means technically.
Don't forget to write a unit test for it.