[header] Header should not be visible if no title is set by default
Bug #1162028 reported by
Pat McGowan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UI Toolkit |
Fix Released
|
High
|
Tim Peeters | ||
Bug Description
The mainview now includes a header by default, The intention in the code seems to be that it is hidden by default if no title is set, but it is shown with blank text. This would force the app to have a Page object and explicitly clear the title.
Initializing y to -height instead of 0 in Header.qml resolves it.
Related branches
lp:~tpeeters/ubuntu-ui-toolkit/emptyHeader
- PS Jenkins bot: Approve (continuous-integration)
- Zoltan Balogh: Pending requested
-
Diff: 136 lines (+58/-29)3 files modifiedmodules/Ubuntu/Components/Header.qml (+5/-5)
modules/Ubuntu/Components/Page.qml (+1/-1)
tests/unit/tst_components/tst_page.qml (+52/-23)
Revision history for this message
| Pat McGowan (pat-mcgowan) wrote | #1 |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | nobody → Gerry Boland (gerboland) |
Revision history for this message
| Tim Peeters (tpeeters) wrote | #2 |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | Gerry Boland (gerboland) → Tim Peeters (tpeeters) |
| Changed in ubuntu-ui-toolkit: | |
| status: | New → In Progress |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Undecided → High |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in ubuntu-ui-toolkit: | |
| status: | In Progress → Fix Committed |
| summary: |
- Header should not be visible if no title is set by default + [header] Header should not be visible if no title is set by default |
| Changed in ubuntu-ui-toolkit: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I just saw that a fix for this in rev 399 was reverted for some reason