add-apt-repository i18n problems
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Translations |
Fix Released
|
Medium
|
Unassigned | ||
software-properties (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
There are some small i18n problems in add-apt-repository:
- some parentheses are misplaced around translatable strings
- strings with multiple %s's are not using named arguments, so they are not reorderable. To properly translate, I'd like to reorder them.
- there is no textdomain set, so gettext doesn't know where to look for the strings
- strings in the output of --help are not marked for translation. They also need to workaround optparser's lack of utf8 awareness.
- the big usage help text should be broken up into smaller pieces to make its translation easier to maintain.
I'll attach a branch for most of these, but I couldn't figure out how to solve everything of the above, so it's still going to need some work.
Related branches
- Timo Aaltonen: Approve
- Robert Roth (community): Approve
-
Diff: 93 lines (+26/-14)1 file modifiedadd-apt-repository (+26/-14)
- No reviews requested
Changed in software-properties (Ubuntu): | |
status: | New → Confirmed |
Changed in ubuntu-translations: | |
status: | New → Triaged |
importance: | Undecided → Medium |
The branch fixes mentioned problems except the last, but there is a small problem I don't like:
The --help output has this line:
help=_("URL of keyserver. Default: %default" ).decode( enc))
Now because this is in an extensionless file, xgettext thinks this is a C file and above is a C format string, which makes it possible for translators to break the %default variable into %d + some text. This needs some more work. Also for the same reason translator comments are not extracted, which I don't like either.
For the big usage text, I have not found an elegant way to mark it for translation, so that needs the help of someone more experienced with Python.