libgweather-locations.pot generation fails with bionic meson

[Jeremy Bícha]

From bionic:

Change to the libgweather source directory and run

sudo apt build-dep libgweather
dh_auto_configure
dh_auto_build

ninja -v -C obj-x86_64-linux-gnu/ libgweather-3.0-pot
ninja -v -C obj-x86_64-linux-gnu/ libgweather-locations-pot

For reference, the second to last command succeeds with this output:
---------------
ninja -v -C obj-x86_64-linux-gnu/ libgweather-3.0-pot
ninja: Entering directory `obj-x86_64-linux-gnu/'
[0/1] /usr/bin/python3 /usr/bin/meson --internal commandrunner /home/jeremy/devel/libgweather /home/jeremy/devel/libgweather/obj-x86_64-linux-gnu po /usr/bin/python3 /usr/bin/meson /usr/bin/python3 /usr/bin/meson --internal gettext pot --pkgname=libgweather-3.0 --extra-args=--keyword=_@@--add-comments@@--flag=g_set_error:4:c-format@@--flag=N_:1:pass-c-format@@--flag=g_dngettext:2:pass-c-format@@--keyword=NC_:1c,2@@--flag=g_error_new:3:c-format@@--from-code=UTF-8@@--keyword=g_dpgettext2:2c,3@@--keyword=C_:1c,2@@--keyword=g_dngettext:2,3@@--keyword=N_@@--flag=g_string_printf:2:c-format@@--flag=g_string_append_printf:2:c-format@@--flag=C_:2:pass-c-format@@--keyword=g_dcgettext:2@@--flag=NC_:2:pass-c-format@@--flag=g_strdup_printf:1:c-format

The last command fails with this output:
-------------------
ninja: Entering directory `obj-x86_64-linux-gnu/'
[0/1] /usr/bin/python3 /usr/bin/meson --internal commandrunner
 /home/jeremy/devel/libgweather
 /home/jeremy/devel/libgweather/obj-x86_64-linux-gnu po-locations
 /usr/bin/python3 /usr/bin/meson /usr/bin/python3 /usr/bin/meson
 --internal gettext pot --pkgname=libgweather-locations
 --extra-args=--its@@/home/jeremy/devel/libgweather/po-locations/../data/locations.its
FAILED: meson-libgweather-locations-pot
/usr/bin/python3 /usr/bin/meson --internal commandrunner
 /home/jeremy/devel/libgweather
 /home/jeremy/devel/libgweather/obj-x86_64-linux-gnu po-locations
 /usr/bin/python3 /usr/bin/meson /usr/bin/python3 /usr/bin/meson
 --internal gettext pot --pkgname=libgweather-locations
 --extra-args=--its@@/home/jeremy/devel/libgweather/po-locations/../data/locations.its
ninja: build stopped: subcommand failed.

[Gunnar Hjalmarsson (gunnarhj)]

It's a xgettext() issue. I built gettext in a PPA with an upstream commit which fixes it:

https://launchpad.net/~gunnarhj/+archive/ubuntu/gettext

[Launchpad Janitor (janitor)]

This bug was fixed in the package libgweather - 3.27.4-1ubuntu3

---------------
libgweather (3.27.4-1ubuntu3) bionic; urgency=medium

  * Be sure to handle the locations translation template too.
    Thanks Gunnar Hjalmarsson for the assistance. (LP: #1751261)

 -- Jeremy Bicha <email address hidden> Fri, 23 Feb 2018 16:50:16 -0500

[Gunnar Hjalmarsson (gunnarhj)]

@Jeremy: I see that you used my "|| true" idea. ;) Seems to have worked, even if I don't see that anything was imported by LP (but that's another side of the story).

But it's still motivated to update gettext with that patch, right?

[Gunnar Hjalmarsson (gunnarhj)]

The fix of the xgettext() issue should probably be done in Debian to be useful. So I filed <https://bugs.debian.org/891347> with an attached Debian debdiff.

[Jeremy Bícha (jbicha)]

This bug was fixed in the package gettext - 0.19.8.1-5

---------------
gettext (0.19.8.1-5) unstable; urgency=medium

  * Fix heap corruption in msgunfmt. Patch from Bruno Haible taken from
    upstream git. Thanks to Jakub Wilk. Closes: #876498.
  * Recommend lynx instead on lynx-cur.
    Thanks to Axel Beckert for the report. Closes: #882284.
  * Stop xgettext() from crashing when run with --its=FILE option.
    Patch taken from git. Thanks to Gunnar Hjalmarsson. Closes: #891347.
  * Support "nojava" instead of "stage1" in DEB_BUILD_PROFILES.
    Thanks to Manuel Fernández Montecelo. Closes: #893064.
  * Build with OpenJDK 9. Patch from Tiago Stürmer Daitx, adapted
    from openSUSE. Thanks a lot. Closes: #893739.
  * Move libgettextsrc, libgettextlib, and preloadable_libintl
    to multiarch directory as done on Ubuntu.
  * Use https in Bug-Debian field of Debian patches.

 -- Santiago Vila <email address hidden> Sat, 24 Mar 2018 12:24:50 +0100