SMS notification: time format not translatable
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Canonical System Image |
High
|
kevin gunn | ||
| | Ubuntu Translations |
Low
|
Unassigned | ||
| | ubuntu-settings-components (Ubuntu) |
High
|
Nick Dedekind | ||
| | ubuntu-ui-toolkit (Ubuntu) |
High
|
Christian Dywan | ||
| | unity8 (Ubuntu) |
High
|
Nick Dedekind | ||
Bug Description
See the attached screenshot. The time for the notification seems to be hardcoded to "hh:mm - mm, d". This works well for the US, but it's not a format that is used in all other countries. In Spain, for example, the date would rather be "d mm".
The time format needs to be marked for translation.
Not sure from which project the notifications come from, for some reason I seem to remember they were moved to u-s-s, but if it's the wrong project/package, please reassign. Thanks!
Related branches
- Andrea Cimitan (community): Approve on 2015-10-07
- Lukáš Tinkl (community): Approve on 2015-10-07
- PS Jenkins bot (community): Approve (continuous-integration) on 2015-01-12
-
Diff: 15 lines (+2/-2)1 file modifiedUbuntu/Settings/Components/MessageHeader.qml (+2/-2)
- Lukáš Tinkl (community): Approve on 2015-10-21
- Albert Astals Cid (community): Approve on 2015-09-30
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-09-30
-
Diff: 1341 lines (+100/-847)16 files modifieddebian/control (+3/-3)
plugins/Utils/CMakeLists.txt (+0/-2)
plugins/Utils/plugin.cpp (+0/-5)
plugins/Utils/relativetimeformatter.cpp (+0/-260)
plugins/Utils/relativetimeformatter.h (+0/-34)
plugins/Utils/timeformatter.cpp (+0/-206)
plugins/Utils/timeformatter.h (+0/-68)
qml/Panel/Indicators/MenuItemFactory.qml (+19/-15)
qml/Panel/Indicators/MessageMenuItemFactory.qml (+35/-26)
tests/mocks/Utils/CMakeLists.txt (+0/-2)
tests/mocks/Utils/Utils.qmltypes (+31/-28)
tests/mocks/Utils/plugin.cpp (+0/-13)
tests/plugins/Utils/CMakeLists.txt (+0/-1)
tests/plugins/Utils/TimeFormatterTest.cpp (+0/-155)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+6/-16)
tests/qmltests/Panel/Indicators/tst_MessageMenuItemFactory.qml (+6/-13)
- PS Jenkins bot: Approve (continuous-integration) on 2015-08-12
- Zsombor Egri (community): Approve on 2015-08-12
-
Diff: 702 lines (+624/-2)9 files modifiedcomponents.api (+10/-0)
src/Ubuntu/Components/plugin/livetimer.cpp (+142/-0)
src/Ubuntu/Components/plugin/livetimer.h (+68/-0)
src/Ubuntu/Components/plugin/livetimer_p.cpp (+169/-0)
src/Ubuntu/Components/plugin/livetimer_p.h (+58/-0)
src/Ubuntu/Components/plugin/plugin.cpp (+2/-0)
src/Ubuntu/Components/plugin/plugin.pri (+7/-2)
src/Ubuntu/Components/plugin/timeutils_p.h (+117/-0)
tests/unit/tst_components/tst_livetimer.qml (+51/-0)
- Lukáš Tinkl (community): Needs Fixing (code-review) on 2015-09-17
- PS Jenkins bot: Approve (continuous-integration) on 2015-08-12
- Zsombor Egri (community): Approve on 2015-08-12
-
Diff: 679 lines (+512/-24)12 files modifiedcomponents.api (+1/-0)
src/Ubuntu/Components/plugin/i18n.cpp (+74/-0)
src/Ubuntu/Components/plugin/i18n.h (+1/-0)
src/Ubuntu/Components/plugin/timeutils_p.h (+24/-0)
tests/unit/tst_i18n/tst_i18n.pro (+3/-18)
tests/unit/tst_i18n/tst_i18n_LocalizedApp/src/LocalizedApp.qml (+43/-1)
tests/unit/tst_i18n/tst_i18n_LocalizedApp/src/tst_i18n_LocalizedApp.cpp (+5/-5)
tests/unit/tst_i18n/tst_i18n_LocalizedApp/tst_i18n_LocalizedApp.pro (+17/-0)
tests/unit/tst_i18n/tst_i18n_RelativeTime/po/en_US.po (+54/-0)
tests/unit/tst_i18n/tst_i18n_RelativeTime/src/RelativeTime.qml (+71/-0)
tests/unit/tst_i18n/tst_i18n_RelativeTime/src/tst_i18n_RelativeTime.cpp (+202/-0)
tests/unit/tst_i18n/tst_i18n_RelativeTime/tst_i18n_RelativeTime.pro (+17/-0)
| David Planella (dpm) wrote : | #1 |
| tags: | added: touch |
| description: | updated |
| Changed in ubuntu-translations: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| Sebastien Bacher (seb128) wrote : | #2 |
| affects: | ubuntu-system-settings (Ubuntu) → telephony-service (Ubuntu) |
| Changed in telephony-service (Ubuntu): | |
| importance: | Undecided → High |
| assignee: | nobody → Tiago Salem Herrmann (tiagosh) |
| tags: | added: rtm14 touch-2014-10-23 |
| no longer affects: | indicator-messages (Ubuntu) |
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Nick Dedekind (nick-dedekind) |
| Nick Dedekind (nick-dedekind) wrote : | #3 |
This should be using the datetime indicator translation context, perhaps this is wrong?
We're meaning to move the relative time formatters to the sdk to get consistency.
| kevin gunn (kgunn72) wrote : | #4 |
@nick - so should we just move this bug to sdk ?
| tags: |
added: ota-1 removed: touch-2014-10-23 |
| Changed in unity8 (Ubuntu): | |
| assignee: | Nick Dedekind (nick-dedekind) → Ying-Chun Liu (paulliu) |
| assignee: | Ying-Chun Liu (paulliu) → Nick Dedekind (nick-dedekind) |
| Changed in unity8 (Ubuntu RTM): | |
| assignee: | nobody → Nick Dedekind (nick-dedekind) |
| Changed in unity8 (Ubuntu): | |
| importance: | Undecided → High |
| Changed in unity8 (Ubuntu RTM): | |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in unity8 (Ubuntu): | |
| status: | New → Triaged |
| Changed in unity8 (Ubuntu): | |
| status: | Triaged → In Progress |
| Nick Dedekind (nick-dedekind) wrote : | #5 |
This is due to the datetime indicator no longer having relative time formatting; so the cross domain usage for translated time formats in unity8 is no longer in sync.
Highlights the problem of inconsistency, and the need to move this to sdk.
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Canonical Devices Products (canonical-devices-products-team) |
| importance: | Undecided → High |
| milestone: | none → r1 |
| status: | New → Confirmed |
| Changed in unity8 (Ubuntu RTM): | |
| assignee: | Nick Dedekind (nick-dedekind) → nobody |
| milestone: | none → 14.09-ota-1 |
| Bill Filler (bfiller) wrote : | #6 |
the formatting is done outside of the telephony-service which just passes a timestamp to the messaging-menu, so marking invalid for telephony-service
| Changed in telephony-service (Ubuntu): | |
| status: | New → Invalid |
| Nick Dedekind (nick-dedekind) wrote : | #7 |
Currently in unity8 we rely on indicator-datetime translations for time string formats; but since these are no longer in sync with the one's used in unity8, it's not working.
I'm moving the time formatter into the sdk where the translations will be done.
Everything (messaging & alarm/events) should be passing around "time stamps" rather than "time strings", which can be formatted & translated by the UIs inconsistently.
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Nick Dedekind (nick-dedekind) |
| Michał Sawicz (saviq) wrote : | #8 |
Let's target this for ww03-2015.
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → New |
| Changed in unity8 (Ubuntu RTM): | |
| milestone: | 14.09-ota-1 → none |
| Changed in canonical-devices-system-image: | |
| milestone: | ww51-2014 → ww03-2015 |
| Changed in ubuntu-settings-components (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Nick Dedekind (nick-dedekind) |
| Changed in ubuntu-settings-components (Ubuntu RTM): | |
| status: | New → Triaged |
| milestone: | none → 14.09-ota-2 |
| Changed in unity8 (Ubuntu RTM): | |
| milestone: | none → 14.09-ota-2 |
| Changed in ubuntu-settings-components (Ubuntu RTM): | |
| milestone: | 14.09-ota-2 → 14.09-release |
| Changed in unity8 (Ubuntu RTM): | |
| milestone: | 14.09-ota-2 → 14.09-release |
| Changed in ubuntu-settings-components (Ubuntu RTM): | |
| importance: | Undecided → High |
| Changed in canonical-devices-system-image: | |
| status: | New → Confirmed |
| Changed in canonical-devices-system-image: | |
| milestone: | ww03-2015 → ww05-2015 |
| status: | Confirmed → In Progress |
| Pat McGowan (pat-mcgowan) wrote : | #9 |
review the api for inclusion in sdk post rtm
| Changed in canonical-devices-system-image: | |
| milestone: | ww05-2015 → ww07-2015 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | Nick Dedekind (nick-dedekind) → Zsombor Egri (zsombi) |
| Changed in canonical-devices-system-image: | |
| assignee: | Canonical Devices Products (canonical-devices-products-team) → Kevin Gunn (kgunn) |
| milestone: | ww07-2015 → ww09-2015 |
| Michał Sawicz (saviq) wrote : | #10 |
The required API was not accepted into UITK yet, ww09 seems like an impossible target for this.
| Changed in unity8 (Ubuntu RTM): | |
| milestone: | 14.09-release → 14.09-ota-1 |
| Changed in unity8 (Ubuntu RTM): | |
| milestone: | 14.09-ota-1 → none |
| Changed in ubuntu-settings-components (Ubuntu RTM): | |
| milestone: | 14.09-release → none |
| Changed in canonical-devices-system-image: | |
| milestone: | ww09-2015 → ww13-2015 |
| assignee: | Kevin Gunn (kgunn) → Zoltan Balogh (bzoltan) |
| Changed in canonical-devices-system-image: | |
| milestone: | ww13-2015 → ww17-2015 |
| Pat McGowan (pat-mcgowan) wrote : | #11 |
whats going on with this, seems stalled
| Changed in canonical-devices-system-image: | |
| milestone: | ww17-2015 → ww21-2015 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| importance: | Undecided → High |
| Zsombor Egri (zsombi) wrote : | #12 |
The branch proposed for the toolkit does not cover the BP https:/
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | Zsombor Egri (zsombi) → Christian Dywan (kalikiana) |
| Nick Dedekind (nick-dedekind) wrote : | #13 |
I used a component because using function won't respond to changes in locale, time-zone, daylight savings, etc without a refresh of the data.
It's a lot more complicated than just a i18n.tr("12:00 PM") kind of thing. Unless you have a better idea (other than ignoring changes).
| Pat McGowan (pat-mcgowan) wrote : | #14 |
Can we get some action on this
| Changed in canonical-devices-system-image: | |
| milestone: | ww21-2015 → ww26-2015 |
| Changed in canonical-devices-system-image: | |
| milestone: | ww26-2015 → ww34-2015 |
| Zsombor Egri (zsombi) wrote : | #15 |
Nick, you can get updates on function calls when local or any parameter used changes. See i18n.tr() and other functions also get updated when locale changes. You could have thing like i18n.trDate(date, format) which returns an object, which in turn can also have properties/
| Changed in canonical-devices-system-image: | |
| milestone: | ww34-2015 → ww40-2015 |
| assignee: | Zoltan Balogh (bzoltan) → kevin gunn (kgunn72) |
| no longer affects: | telephony-service (Ubuntu) |
| no longer affects: | ubuntu-settings-components (Ubuntu RTM) |
| no longer affects: | ubuntu-ui-toolkit (Ubuntu RTM) |
| no longer affects: | unity8 (Ubuntu RTM) |
| Changed in ubuntu-settings-components (Ubuntu): | |
| importance: | Undecided → High |
| Changed in canonical-devices-system-image: | |
| milestone: | ww40-2015 → ww46-2015 |
| Launchpad Janitor (janitor) wrote : | #16 |
This bug was fixed in the package ubuntu-
---------------
ubuntu-
[ CI Train Bot ]
* New rebuild forced.
[ Nick Dedekind ]
* Fixed problem with message time text alignment. (LP: #1372061,
#1378821)
ubuntu-
[ CI Train Bot ]
* New rebuild forced.
[ Daniel d'Andrada ]
* Avoid creating a deluge of deprecation warnings
[ Lukáš Tinkl ]
* Use the standalone month name for the calendar caption
[ Nick Dedekind ]
* Crop icons to aspect ratio inside UbuntuShapes. (LP: #1450229)
ubuntu-
[ CI Train Bot ]
* New rebuild forced.
[ Lukáš Tinkl ]
* Setup message extraction, load the catalog from the plugins (LP:
#1436912)
ubuntu-
[ Michael Zanetti ]
* Tell the layout what size we want the icons to be
[ Nick Dedekind ]
* Don't use preferred values inside Standard item compoonent Loader.
(LP: #1448716)
* Multiline support for message replies (lp#1396058) (LP: #1396058)
ubuntu-
[ CI Train Bot ]
* New rebuild forced.
[ Nick Dedekind ]
* ServerPropertyS
the control is no longer buffering.
ubuntu-
[ Nick Dedekind ]
* Added ServerActivatio
[ CI Train Bot ]
* New rebuild forced.
ubuntu-
[ Sebastien Bacher ]
* Updated version, so the users of the new property can update their depends
ubuntu-
* Added SyncSwitch & SyncCheckBox components
ubuntu-
[ Sebastien Bacher ]
* Get the string translation from telephony-service, that's a
workaround but ubuntu-
translations (LP: #1389234)
ubuntu-
[ Nick Dedekind ]
* Enable send button on input composition (LP: #1369737)
ubuntu-
* New rebuild forced
ubuntu-
[ Nick Dedekind ]
* Added ability to use try*. Added target for test files in qcreator.
ubuntu-
[ Nick Dedekind ]
* Updated components UI for design review
ubuntu-
[ Nick Dedekind ]
* Added plugin module for Ubuntu.
* Added TransferMenu
ubuntu-
* debian/control:
list qtdeclarative5-
choice, since...
| Changed in ubuntu-settings-components (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in unity8 (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |


settings has notifications for system updates only, that's probably an issue with telephony-service rather