[browser] Missing popover on bookmarking the current page
Bug #1351147 reported by
Olivier Tilloy
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Translations |
New
|
Undecided
|
Unassigned | ||
| Ubuntu UX |
Fix Released
|
High
|
James Mulholland | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Arthur Mello | ||
Bug Description
The design spec calls for a popover to be displayed with the title of the current page when it is being bookmarked (page 23 of the spec).
Related branches
lp:~artmello/webbrowser-app/webbrowser-app-bookmark_folders
- Olivier Tilloy: Approve
- PS Jenkins bot: Approve (continuous-integration)
- Bill Filler (community): Needs Fixing
-
Diff: 2658 lines (+1979/-70)27 files modifiedsrc/app/webbrowser/AddressBar.qml (+7/-0)
src/app/webbrowser/BookmarkOptions.qml (+166/-0)
src/app/webbrowser/BookmarksFolderListView.qml (+157/-0)
src/app/webbrowser/Browser.qml (+64/-4)
src/app/webbrowser/CMakeLists.txt (+2/-0)
src/app/webbrowser/Chrome.qml (+2/-0)
src/app/webbrowser/NewTabView.qml (+27/-9)
src/app/webbrowser/UrlsList.qml (+2/-2)
src/app/webbrowser/bookmarks-folder-model.cpp (+84/-0)
src/app/webbrowser/bookmarks-folder-model.h (+60/-0)
src/app/webbrowser/bookmarks-folderlist-model.cpp (+217/-0)
src/app/webbrowser/bookmarks-folderlist-model.h (+79/-0)
src/app/webbrowser/bookmarks-model.cpp (+164/-8)
src/app/webbrowser/bookmarks-model.h (+15/-3)
src/app/webbrowser/webbrowser-app.cpp (+2/-0)
tests/autopilot/webbrowser_app/emulators/browser.py (+52/-0)
tests/autopilot/webbrowser_app/tests/test_addressbar_bookmark.py (+3/-0)
tests/autopilot/webbrowser_app/tests/test_bookmark_options.py (+243/-0)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+6/-2)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+150/-22)
tests/autopilot/webbrowser_app/tests/test_suggestions.py (+2/-2)
tests/unittests/CMakeLists.txt (+2/-0)
tests/unittests/bookmarks-folder-model/CMakeLists.txt (+6/-0)
tests/unittests/bookmarks-folder-model/tst_BookmarksFolderModelTests.cpp (+123/-0)
tests/unittests/bookmarks-folderlist-model/CMakeLists.txt (+6/-0)
tests/unittests/bookmarks-folderlist-model/tst_BookmarksFolderListModelTests.cpp (+269/-0)
tests/unittests/bookmarks-model/tst_BookmarksModelTests.cpp (+69/-18)
| Changed in webbrowser-app: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in webbrowser-app: | |
| assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
| assignee: | Giorgio Venturi (giorgio-venturi) → nobody |
| Changed in ubuntu-ux: | |
| assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
| importance: | Undecided → Medium |
| status: | New → Fix Committed |
| summary: |
- Missing popover on bookmarking the current page + [browser] Missing popover on bookmarking the current page |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Confirmed |
| tags: | added: design-gap |
| Changed in ubuntu-ux: | |
| assignee: | Giorgio Venturi (giorgio-venturi) → James Mulholland (jamesjosephmulholland) |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Arthur Mello (artmello) |
| importance: | Undecided → High |
| no longer affects: | webbrowser-app |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
Revision history for this message
| James Mulholland (jamesmulholland) wrote | #2 |
| Changed in ubuntu-ux: | |
| importance: | Medium → High |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+15.
---------------
webbrowser-app (0.23+15.
[ Arthur Mello ]
* Implement bookmark folders (LP: #1351147, #1259247)
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk.
-- CI Train Bot <email address hidden> Thu, 02 Jul 2015 20:09:10 +0000