Infographic's language not updated until the metric value is changed
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Canonical System Image |
Medium
|
Unassigned | ||
| | Ubuntu Music App |
Undecided
|
Unassigned | ||
| | Ubuntu Translations |
Medium
|
Unassigned | ||
| | camera-app (Ubuntu) |
Medium
|
Unassigned | ||
| | libusermetrics (Ubuntu) |
High
|
Unassigned | ||
| | libusermetrics (Ubuntu RTM) |
High
|
Unassigned | ||
Bug Description
1) Start the music app
2) Play a track for more than 10 seconds to trigger the metric update
3) Lock and unlock to show the infographic
4) Note, for example, "1 song played today" appears (double tap to cycle through to find music if required)
5) Goto system settings and change the language
6) Restart the device
7) Note the infographic's language has not been updated and it still states '1 song played today'
8) Start the music app
9) Play a track for more than 10 seconds to trigger the metric update
10) Lock and unlock to show the infographic
11) Now notice the infographic's language is now correct, for example "2 Morceaux joues aujourd'hui"
It was expected that step 7 the infographic would show the correct language.
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-02-18
- Unity Team: Pending requested 2015-02-18
-
Diff: 865 lines (+261/-56)21 files modifiedCMakeLists.txt (+10/-1)
data/com.canonical.usermetrics.DataSource.xml (+2/-0)
debian/control (+1/-0)
src/libusermetricscommon/DateFactory.h (+1/-0)
src/libusermetricsoutput/SyncedDataSource.cpp (+2/-2)
src/libusermetricsoutput/SyncedDataSource.h (+1/-1)
src/libusermetricsoutput/SyncedUserMetricsStore.cpp (+3/-5)
src/libusermetricsoutput/SyncedUserMetricsStore.h (+1/-3)
src/usermetricsservice/CMakeLists.txt (+6/-2)
src/usermetricsservice/DBusDataSet.h (+1/-0)
src/usermetricsservice/DBusDataSource.cpp (+9/-2)
src/usermetricsservice/DBusDataSource.h (+14/-1)
src/usermetricsservice/DBusUserMetrics.cpp (+5/-4)
src/usermetricsservice/DBusUserMetrics.h (+5/-1)
src/usermetricsservice/TranslationLocator.h (+34/-0)
src/usermetricsservice/TranslationLocatorImpl.cpp (+69/-0)
src/usermetricsservice/TranslationLocatorImpl.h (+34/-0)
src/usermetricsservice/main.cpp (+3/-1)
tests/data/valgrind.suppression (+15/-0)
tests/integration/libusermetricsoutput/TestUserMetrics.cpp (+3/-3)
tests/unit/usermetricsservice/TestUserMetricsService.cpp (+42/-30)
- Unity Team: Pending requested 2015-01-29
-
Diff: 865 lines (+261/-56)21 files modifiedCMakeLists.txt (+10/-1)
data/com.canonical.usermetrics.DataSource.xml (+2/-0)
debian/control (+1/-0)
src/libusermetricscommon/DateFactory.h (+1/-0)
src/libusermetricsoutput/SyncedDataSource.cpp (+2/-2)
src/libusermetricsoutput/SyncedDataSource.h (+1/-1)
src/libusermetricsoutput/SyncedUserMetricsStore.cpp (+3/-5)
src/libusermetricsoutput/SyncedUserMetricsStore.h (+1/-3)
src/usermetricsservice/CMakeLists.txt (+6/-2)
src/usermetricsservice/DBusDataSet.h (+1/-0)
src/usermetricsservice/DBusDataSource.cpp (+9/-2)
src/usermetricsservice/DBusDataSource.h (+14/-1)
src/usermetricsservice/DBusUserMetrics.cpp (+5/-4)
src/usermetricsservice/DBusUserMetrics.h (+5/-1)
src/usermetricsservice/TranslationLocator.h (+34/-0)
src/usermetricsservice/TranslationLocatorImpl.cpp (+69/-0)
src/usermetricsservice/TranslationLocatorImpl.h (+34/-0)
src/usermetricsservice/main.cpp (+3/-1)
tests/data/valgrind.suppression (+15/-0)
tests/integration/libusermetricsoutput/TestUserMetrics.cpp (+3/-3)
tests/unit/usermetricsservice/TestUserMetricsService.cpp (+42/-30)
- Andrew Hayzen: Needs Fixing on 2015-03-11
- Victor Thompson: Needs Fixing on 2015-03-11
- David Planella: Pending requested 2015-02-02
-
Diff: 3589 lines (+609/-565)69 files modifiedmusic-app.qml (+2/-2)
po/CMakeLists.txt (+1/-0)
po/am.po (+2/-2)
po/ar.po (+2/-2)
po/ast.po (+42/-38)
po/az.po (+1/-1)
po/be.po (+2/-2)
po/bg.po (+2/-2)
po/bn.po (+1/-1)
po/br.po (+2/-2)
po/ca.po (+2/-2)
po/ca@valencia.po (+43/-40)
po/ckb.po (+1/-1)
po/com.ubuntu.music.pot (+36/-36)
po/cs.po (+2/-2)
po/da.po (+2/-2)
po/de.po (+42/-38)
po/el.po (+42/-38)
po/en_AU.po (+2/-2)
po/en_GB.po (+2/-2)
po/eo.po (+1/-1)
po/es.po (+2/-2)
po/eu.po (+2/-2)
po/fa.po (+46/-42)
po/fi.po (+2/-2)
po/fo.po (+1/-1)
po/fr.po (+2/-2)
po/gd.po (+44/-40)
po/gl.po (+2/-2)
po/he.po (+2/-2)
po/hr.po (+1/-1)
po/hu.po (+2/-2)
po/id.po (+2/-2)
po/is.po (+2/-2)
po/it.po (+2/-2)
po/ja.po (+2/-2)
po/km.po (+2/-2)
po/kn.po (+1/-1)
po/ko.po (+2/-2)
po/lv.po (+1/-1)
po/mi.po (+1/-1)
po/ml.po (+1/-1)
po/mr.po (+1/-1)
po/ms.po (+2/-2)
po/my.po (+2/-2)
po/nb.po (+2/-2)
po/nl.po (+2/-2)
po/pa.po (+47/-45)
po/pl.po (+2/-2)
po/ps.po (+1/-1)
po/pt.po (+42/-38)
po/pt_BR.po (+2/-2)
po/ro.po (+44/-40)
po/ru.po (+2/-2)
po/shn.po (+1/-1)
po/si.po (+1/-1)
po/sl.po (+1/-1)
po/sq.po (+1/-1)
po/sr.po (+2/-2)
po/st.po (+1/-1)
po/sv.po (+2/-2)
po/ta.po (+1/-1)
po/te.po (+1/-1)
po/tr.po (+42/-38)
po/ug.po (+2/-2)
po/uk.po (+2/-2)
po/zh_CN.po (+45/-39)
po/zh_HK.po (+2/-2)
po/zh_TW.po (+2/-2)
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-02-23
- Ubuntu Phablet Team: Pending requested 2015-02-23
-
Diff: 38 lines (+5/-5)2 files modifiedcamera-app.qml (+4/-4)
po/CMakeLists.txt (+1/-1)
| Changed in ubuntu-translations: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| tags: | added: touch |
| no longer affects: | libusermetrics |
| Nicholas Skaggs (nskaggs) wrote : | #2 |
This is still in effect. I noticed this without the music application, but changing language causes the infographic to stay in the original language (seemingly until it's value would be changed)
| tags: | added: touch-l10n |
| Changed in libusermetrics (Ubuntu): | |
| importance: | Undecided → High |
| status: | New → Confirmed |
| John McAleely (john.mcaleely) wrote : | #3 |
It seems likely this will appear at launch, when we ship Spanish images that get flipped to english by some users: bug #1404890
| John McAleely (john.mcaleely) wrote : | #4 |
Can someone triage this on to a milestone for canonical-
| Changed in libusermetrics (Ubuntu): | |
| assignee: | nobody → Thomas Strehl (strehl-t) |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → Medium |
| milestone: | none → ww09-2015 |
| status: | New → Confirmed |
| Changed in libusermetrics (Ubuntu): | |
| assignee: | Thomas Strehl (strehl-t) → Pete Woods (pete-woods) |
| Changed in libusermetrics (Ubuntu): | |
| status: | Confirmed → In Progress |
| Noemí (noemi-gallego) wrote : | #5 |
I've detected that when the device language is in portuguese, the today page is written in english. Do you know if this is happening in any other languages?
In spanish it doesn't happen.
| Pete Woods (pete-woods) wrote : | #6 |
I've attached a branch that allows the infographics to read translations from click packages in addition to the standard language packs.
I've confirmed that this works.
However, the translations for the music app infographics need updating. In its codebase it actually pre-translates the strings before it sends them to the infographics server. What it *should* be doing is tagging the strings from translation, but not translating them itself. Usually you can do this with a dummy pass-through function as below:
function translateMe(s) {
return s;
}
Metric {
id: songsMetric
name: "music-metrics"
format: translateMe("Songs played today: <b>%1</b>")
domain: "com.ubuntu.music"
}
and then configure gettext to extract this function.
| Pete Woods (pete-woods) wrote : | #7 |
I've attached a branch for the music app that does the programming part of the fix. Now we need to update the translated strings.
| Pete Woods (pete-woods) wrote : | #8 |
Blocked on bug #1417031
| Noemí (noemi-gallego) wrote : | #9 |
Hi,
This is a list of things that appear in english while having the device in a different language:
German:
- Today Scope -> Settings -> Enable location data.
- Nearby scope -> Settings -> Enable location data
- App scope -> Options -> All os them in english
- Music scope: popular tracks on souncloud, popular tracks on youtube
- Music scope -> Settings -> Half of the options in english
- Video scope: vimeo features
- Video scope -> Settings -> Half in english
- System settings -> Rotation lock
French:
- Today Scope -> Settings -> Enable location data.
- Nearby scope -> Settings -> Enable location data
- App scope -> Options -> All os them in english
- Music scope: popular tracks on souncloud, popular tracks on youtube
- Music scope -> Settings -> Half of the options in english
- Video scope -> Settings -> Half in english
Italian:
- Today Scope -> Settings -> Enable location data.
- Nearby scope -> Settings -> Enable location data
- App scope -> Options -> All os them in english
- Music scope: popular tracks on souncloud, popular tracks on youtube
- Music scope -> Settings -> Half of the options in english
- Video scope -> Settings -> Half in english
- Alarm -> New alarm -> All in english
- Notification bar -> Rotation lock
Portugues:
- Today Scope -> Settings -> Enable location data.
- Today Scope -> Add your fitbit account
- Nearby scope -> Settings -> Enable location data
- App scope -> Options -> All os them in english
- Music scope: popular tracks on souncloud, popular tracks on youtube
- Music scope -> Settings -> Half of the options in english
- Video scope -> Settings -> Half in english
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Thomas Strehl (strehl-t) |
| Launchpad Janitor (janitor) wrote : | #10 |
This bug was fixed in the package libusermetrics - 1.1.1+15.
---------------
libusermetrics (1.1.1+
[ Pete Woods ]
* Read translations from click packages (LP: #1327419)
-- CI Train Bot <email address hidden> Thu, 19 Feb 2015 09:31:29 +0000
| Changed in libusermetrics (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in libusermetrics (Ubuntu RTM): | |
| importance: | Undecided → High |
| status: | New → In Progress |
| assignee: | nobody → Pete Woods (pete-woods) |
| Changed in camera-app: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Pete Woods (pete-woods) |
| Changed in music-app: | |
| status: | New → In Progress |
| assignee: | nobody → Pete Woods (pete-woods) |
| Launchpad Janitor (janitor) wrote : | #11 |
This bug was fixed in the package libusermetrics - 1.1.1+15.
---------------
libusermetrics (1.1.1+
[ Pete Woods ]
* Read translations from click packages (LP: #1327419)
-- CI Train Bot <email address hidden> Thu, 19 Feb 2015 09:31:21 +0000
| Changed in libusermetrics (Ubuntu RTM): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| milestone: | ww09-2015 → ww13-ota |
| status: | Confirmed → Fix Released |
| Noemí (noemi-gallego) wrote : | #12 |
Hi,
We have done some testing translating the device into russian. The overall feedback is that the translation into Russian is OK but we have found 5 strings in English instead of Russian. Please see the following screenshots:
| Pat McGowan (pat-mcgowan) wrote : | #13 |
@Naomi this should really be a new bug, would you mind?
| Noemí (noemi-gallego) wrote : | #14 |
@Pat done. Here is the new one: https:/
| Changed in camera-app: | |
| importance: | High → Medium |
| Changed in camera-app (Ubuntu): | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → Pete Woods (pete-woods) |
| no longer affects: | camera-app |
| Changed in canonical-devices-system-image: | |
| assignee: | Thomas Strehl (strehl-t) → nobody |
| Changed in camera-app (Ubuntu): | |
| assignee: | Pete Woods (pete-woods) → nobody |
| Changed in music-app: | |
| assignee: | Pete Woods (pete-woods) → nobody |
| Changed in libusermetrics (Ubuntu RTM): | |
| assignee: | Pete Woods (pete-woods) → nobody |
| Changed in libusermetrics (Ubuntu): | |
| assignee: | Pete Woods (pete-woods) → nobody |


This will become even more true with lp:~unity-team/libusermetrics/file-based-infographics, where we'll need to regenerate the infographics on language change or so.