Switcher widget background goes outside its border

Bug #1719355 reported by Carlo Lobrano on 2017-09-25
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UX
Undecided
Unassigned
Ubuntu theme
Medium
Carlo Lobrano
ubuntu-themes (Ubuntu)
Medium
Carlo Lobrano
Artful
Medium
Carlo Lobrano

Bug Description

[Impact]

In both Ambiance and Radiance themes, the switcher background is visible outside the widget border when inside a headerbar.

See picture from Gnome Control Settings -> Search

[Test case]

1. Open Gnome Control Settings -> Search
2. Ensure that no extra border is around the switcher (especially in the headerbar)

[Regression potential]

Switchers borders are incorrect

Related branches

Carlo Lobrano (c-lobrano) wrote :
Changed in ubuntu-themes:
assignee: nobody → Carlo Lobrano (c-lobrano)
status: New → Confirmed
Daniel van Vugt (vanvugt) wrote :

Incomplete for ubuntu-themes, pending comments from Design.

I really can't tell if the border is an intentional feature or not. Previously I assumed it was intentional but now you mention it, am not sure.

Changed in ubuntu-themes:
status: Confirmed → Incomplete
Changed in ubuntu-themes (Ubuntu):
status: New → Incomplete
Carlo Lobrano (c-lobrano) wrote :

I considered how switchers look like in headerbar vs other places and the first does not look really right, but I understand your point.

Iain Lane (laney) wrote :

It's not supposed to look like this, we just messed up when writing the theme somehow

Changed in ubuntu-themes:
status: Incomplete → Triaged
Changed in ubuntu-themes (Ubuntu):
status: Incomplete → Triaged
importance: Undecided → Medium
Changed in ubuntu-themes:
importance: Undecided → Medium
Carlo Lobrano (c-lobrano) wrote :

Hi Laney, do you think this solution is acceptable?

Changed in ubuntu-themes:
status: Triaged → In Progress
Changed in ubuntu-themes (Ubuntu):
assignee: nobody → Carlo Lobrano (c-lobrano)
status: Triaged → In Progress
description: updated
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-themes - 16.10+18.04.20171114-0ubuntu1

---------------
ubuntu-themes (16.10+18.04.20171114-0ubuntu1) bionic; urgency=medium

  [ Andrea Azzarone ]
  * Fix osd progress bar look. (LP: #1724808)

  [ Carlo Lobrano ]
  * Ambiance, Radiance: fix horizontal linked suggested-action and
    destructive-action (LP: #1721102)
  * Ambiance, Radiance: Fixed border in switcher widget (LP: #1719355)

  [ Marco Trevisan (Treviño) ]
  * Ambiance, Radiance (gtk2): remove undefined "murrine-scrollbar" from
    mate panel (LP: #1723422)
  * Ambiance, Radiance: add theming for headerbar .destructive-action
    button's (LP: #1726318)
  * Ambiance, Radiance: Use inverted gradient for button actions in
    maximized titlebars (LP: #1726322)

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Tue, 14 Nov 2017 17:50:15 +0000

Changed in ubuntu-themes (Ubuntu):
status: In Progress → Fix Released

Hello Carlo, or anyone else affected,

Accepted ubuntu-themes into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-themes/16.10+17.10.20171115-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ubuntu-themes (Ubuntu Artful):
status: New → Fix Committed
tags: added: verification-needed verification-needed-artful
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Artful:
I have reproduced the problem with ubuntu-themes 16.10+17.10.20171012.1-0ubuntu1 in artful and have verified that the version of ubuntu-themes 16.10+17.10.20171115-0ubuntu1 in -proposed fixes the issue.

Marking as verification-done

tags: added: verification-done verification-done-artful
removed: verification-needed verification-needed-artful
Changed in ubuntu-themes (Ubuntu Artful):
importance: Undecided → Medium
assignee: nobody → Carlo Lobrano (c-lobrano)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-themes - 16.10+17.10.20171115-0ubuntu1

---------------
ubuntu-themes (16.10+17.10.20171115-0ubuntu1) artful; urgency=medium

  [ Andrea Azzarone ]
  * Fix osd progress bar look. (LP: #1724808)

  [ Carlo Lobrano ]
  * Ambiance, Radiance: Fixed border in switcher widget (LP: #1719355)
  * Ambiance, Radiance: fix horizontal linked suggested-action and
    destructive-action (LP: #1721102)

  [ Marco Trevisan (Treviño) ]
  * Ambiance, Radiance (gtk2): remove undefined "murrine-scrollbar" from
    mate panel (LP: #1723422)
  * Ambiance, Radiance: add theming for headerbar .destructive-action
    button's (LP: #1726318)
  * Ambiance, Radiance: Use inverted gradient for button actions in
    maximized titlebars (LP: #1726322)

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Wed, 15 Nov 2017 06:59:57 +0000

Changed in ubuntu-themes (Ubuntu Artful):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for ubuntu-themes has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in ubuntu-themes:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers