[indicators] Align indicators correctly to grid units
Bug #1236267 reported by
John Lea
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Released
|
High
|
Alex Milazzo | ||
Ubuntu theme |
Fix Released
|
High
|
Matthieu James | ||
ubuntu-themes (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
unity8 (Ubuntu) |
Fix Released
|
High
|
Nick Dedekind |
Bug Description
Align indicators correctly to grid units. Most indicators need 3gu, but the bluetooth indicator needs only 2gu and the time requires 4gu.
See attached visual designs which include a grid unit underlay showing the correct spacing.
Related branches
lp:~nick-dedekind/unity8/lp1236267
- PS Jenkins bot (community): Approve (continuous-integration)
- Albert Astals Cid (community): Approve
-
Diff: 345 lines (+217/-21)8 files modifiedPanel/Indicators/DefaultIndicatorWidget.qml (+32/-10)
plugins/Unity/Indicators/qml/IndicatorWidget.qml (+1/-1)
tests/mocks/Unity/Indicators/IndicatorBase.qml (+37/-0)
tests/mocks/Unity/Indicators/IndicatorWidget.qml (+28/-0)
tests/mocks/Unity/Indicators/RootActionState.qml (+18/-10)
tests/mocks/Unity/Indicators/qmldir (+2/-0)
tests/qmltests/CMakeLists.txt (+2/-0)
tests/qmltests/Panel/Indicators/tst_DefaultIndicatorWidget.qml (+97/-0)
Changed in unity8: | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
status: | Confirmed → In Progress |
Changed in ubuntu-themes: | |
importance: | Undecided → High |
assignee: | nobody → Matthieu James (tiheum) |
tags: | added: needs-qml-test |
Changed in unity8 (Ubuntu): | |
status: | New → Fix Committed |
Changed in unity8: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-themes: | |
status: | New → Fix Released |
Changed in ubuntu-themes (Ubuntu): | |
status: | New → Fix Released |
Changed in ubuntu-ux: | |
assignee: | John Lea (johnlea) → Alex Milazzo (digitalalex) |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
importance: | Undecided → High |
no longer affects: | unity8 |
To post a comment you must log in.
I don't want to hardcode width values into specific indicators. This will become difficult to maintain later on.
For labels: I can round up the widths to the closest gu. If the "10:00" string takes between 3-4gu, then it will be 4gu.
For icons: We need icons of correct aspect to do custom widths. If you want a 3gu icon in the panel (3gu high), then they must be 1:1 aspect including padding. If you want a 2gu icon then it must be between 2:4 and 2:3 padding inclusive, etc.
Note: For svgs, the document size must be the correct aspect.
I've included an example of the bluetooth icon we need to accomplish this.