Update app to build .pot translation file as part of CMake
Bug #1290814 reported by
Victor Thompson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Calculator App |
Fix Released
|
Low
|
Bartosz Kosiorek | ||
| Ubuntu Calendar App |
Fix Released
|
Low
|
Unassigned | ||
| Ubuntu Clock App |
Fix Released
|
Low
|
Bartosz Kosiorek | ||
| Ubuntu File Manager App |
Fix Released
|
Low
|
Unassigned | ||
| Ubuntu Music App |
Fix Released
|
Low
|
Victor Thompson | ||
| Ubuntu Shorts App |
Triaged
|
Low
|
Unassigned | ||
| Ubuntu Terminal App |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
Since the build processes has moved to cmake, it makes sense to move the .pot file creation to cmake too, so that we don't end up using two build systems.
This involves:
- Converting the po/po.pro file to a CMakeLists.txt file
- Updating the README.translations file to reflect the new process
The detailed changes can be seen in the merge proposal for this same purpose on Weather [1]. Further updates to not only utilize CMake, but also use click-buddy to build the click package and translations were also made to the Weather app [2]. It would be preferable if all apps had similar instructions.
[1] https:/
[2] https:/
Related branches
lp:~dpm/ubuntu-weather-app/fix-cmake-i18n
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Martin Borho: Approve
- Nicholas Skaggs: Pending requested
-
Diff: 138 lines (+42/-21)6 files modified.bzrignore (+11/-3)
CMakeLists.txt (+9/-3)
README.translations (+6/-4)
com.ubuntu.weather_weather.desktop.in.in (+1/-1)
po/CMakeLists.txt (+13/-9)
ubuntu-weather-app.qmlproject (+2/-1)
lp:~vthompson/music-app/1290814-music
- David Planella: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Music App Developers: Pending requested
-
Diff: 733 lines (+170/-202)8 files modified.bzrignore (+14/-3)
CMakeLists.txt (+10/-3)
README.translations (+7/-3)
com.ubuntu.music_music.desktop.in (+1/-1)
music-app.qmlproject (+1/-1)
po/CMakeLists.txt (+14/-9)
po/com.ubuntu.music.pot (+123/-124)
po/po.pro (+0/-58)
lp:~gang65/ubuntu-calculator-app/ubuntu-calculator-app-update-template
- David Planella: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 294 lines (+64/-101)8 files modified.bzrignore (+12/-4)
CMakeLists.txt (+9/-2)
README.translations (+7/-3)
com.ubuntu.calculator_calculator.desktop.in (+1/-1)
po/CMakeLists.txt (+13/-9)
po/com.ubuntu.calculator.pot (+21/-22)
po/po.pro (+0/-59)
ubuntu-calculator-app.qmlproject (+1/-1)
lp:~gang65/ubuntu-clock-app/ubuntu-clock-app-update-translation-template
- PS Jenkins bot: Approve (continuous-integration)
- David Planella: Approve
- Ubuntu Phone Apps Jenkins Bot: Needs Fixing (continuous-integration)
- Nekhelesh Ramananthan: Needs Fixing
- dobey (community): Needs Fixing
-
Diff: 578 lines (+150/-160)11 files modified.bzrignore (+11/-3)
CMakeLists.txt (+13/-5)
README.translations (+5/-3)
click/manifest.json.in (+1/-1)
com.ubuntu.clock_clock.desktop.in.in (+3/-2)
debian/control (+1/-0)
debian/copyright (+1/-0)
po/CMakeLists.txt (+20/-9)
po/com.ubuntu.clock.pot (+94/-73)
po/po.pro (+0/-63)
ubuntu-clock-app.qmlproject (+1/-1)
| Changed in music-app: | |
| importance: | Undecided → Low |
Revision history for this message
| Nicholas Skaggs (nskaggs) wrote | #1 |
| Changed in ubuntu-calculator-app: | |
| status: | New → In Progress |
| importance: | Undecided → Low |
| assignee: | nobody → Riccardo Padovani (rpadovani) |
| Changed in ubuntu-calculator-app: | |
| status: | In Progress → Confirmed |
| assignee: | Riccardo Padovani (rpadovani) → nobody |
| Changed in ubuntu-calendar-app: | |
| status: | New → Triaged |
| Changed in ubuntu-clock-app: | |
| status: | New → Triaged |
| Changed in ubuntu-filemanager-app: | |
| status: | New → Triaged |
| Changed in music-app: | |
| status: | New → Triaged |
| Changed in ubuntu-rssreader-app: | |
| status: | New → Triaged |
| Changed in ubuntu-terminal-app: | |
| status: | New → Triaged |
| Changed in ubuntu-rssreader-app: | |
| importance: | Undecided → Low |
| Changed in ubuntu-terminal-app: | |
| importance: | Undecided → Low |
| Changed in ubuntu-filemanager-app: | |
| importance: | Undecided → Low |
| Changed in ubuntu-clock-app: | |
| importance: | Undecided → Low |
| Changed in ubuntu-calendar-app: | |
| importance: | Undecided → Low |
| Changed in ubuntu-calculator-app: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Bartosz Kosiorek (gang65) |
| description: | updated |
| Changed in music-app: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Victor Thompson (vthompson) |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #2 |
| Changed in music-app: | |
| status: | In Progress → Fix Committed |
| Changed in music-app: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-calculator-app: | |
| assignee: | Bartosz Kosiorek (gang65) → nobody |
| status: | In Progress → Triaged |
| Changed in ubuntu-calculator-app: | |
| assignee: | nobody → Bartosz Kosiorek (gang65) |
| status: | Triaged → In Progress |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #3 |
| Changed in ubuntu-calculator-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-clock-app: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Bartosz Kosiorek (gang65) |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #4 |
| Changed in ubuntu-clock-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-calculator-app: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-calendar-app: | |
| status: | Triaged → Fix Released |
| Changed in ubuntu-filemanager-app: | |
| status: | Triaged → Fix Released |
| Changed in ubuntu-terminal-app: | |
| status: | Triaged → Fix Released |
| Changed in ubuntu-clock-app: | |
| status: | Fix Committed → Fix Released |
| milestone: | none → ota-1 |
To post a comment you must log in.
Awesome Victor! Thanks for updating all of the apps!