[background] Remove initial fallback images
Bug #1223798 reported by
Iain Lane
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-system-settings |
Fix Released
|
Low
|
Łukasz Zemczak | ||
ubuntu-system-settings (Ubuntu) |
Fix Released
|
Low
|
Łukasz Zemczak |
Bug Description
We currently ship some sample images of cogs and a snail in u-s-s as an initial fallback for when an invalid image is selected. This was from when there was no implementation anywhere else of background switching.
We should find out what unity's default background is and set that as the fallback instead of the snail/cogs, then stop including these in u-s-s.
Related branches
lp:~sil2100/ubuntu-system-settings/background_fallback_workaround
- Sebastien Bacher (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 49 lines (+5/-4)2 files modifiedplugins/background/MainPage.qml (+5/-2)
plugins/background/background.pro (+0/-2)
Changed in ubuntu-system-settings: | |
importance: | Undecided → Low |
Changed in ubuntu-system-settings (Ubuntu): | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in ubuntu-system-settings: | |
status: | New → Confirmed |
Changed in ubuntu-system-settings: | |
assignee: | nobody → Łukasz Zemczak (sil2100) |
status: | Confirmed → In Progress |
Changed in ubuntu-system-settings (Ubuntu): | |
assignee: | nobody → Łukasz Zemczak (sil2100) |
status: | Confirmed → In Progress |
To post a comment you must log in.
Hmm, actually there are a couple of cases here
- The background chosen by the user from the application is invalid center or gsettings or whatever) an invalid
+ Maybe refuse the selection and keep what we had previously.
+ Or fall back to Unity's default.
- Externally (via gnome-control-
URL is set. Could be one of these 'timed' xml files or something else
altogether.
+ Trust the shell to do the right thing, perhaps? In a GNOME-like
environment the xml file will be handled correctly and we don't want to
unilaterally overrule this in u-s-s even if we don't know how to show it.
But then what do we display? Not sure.
Probably a Q. for design in there.