[background] Remove initial fallback images

Bug #1223798 reported by Iain Lane on 2013-09-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-system-settings
Fix Released
Low
Łukasz Zemczak
ubuntu-system-settings (Ubuntu)
Low
Łukasz Zemczak

Bug Description

We currently ship some sample images of cogs and a snail in u-s-s as an initial fallback for when an invalid image is selected. This was from when there was no implementation anywhere else of background switching.

We should find out what unity's default background is and set that as the fallback instead of the snail/cogs, then stop including these in u-s-s.

Related branches

Iain Lane (laney) wrote :

Hmm, actually there are a couple of cases here

  - The background chosen by the user from the application is invalid
    + Maybe refuse the selection and keep what we had previously.
    + Or fall back to Unity's default.
  - Externally (via gnome-control-center or gsettings or whatever) an invalid
    URL is set. Could be one of these 'timed' xml files or something else
    altogether.
    + Trust the shell to do the right thing, perhaps? In a GNOME-like
      environment the xml file will be handled correctly and we don't want to
      unilaterally overrule this in u-s-s even if we don't know how to show it.
      But then what do we display? Not sure.

Probably a Q. for design in there.

Changed in ubuntu-system-settings:
importance: Undecided → Low
Changed in ubuntu-system-settings (Ubuntu):
importance: Undecided → Low
status: New → Confirmed
Changed in ubuntu-system-settings:
status: New → Confirmed
Changed in ubuntu-system-settings:
assignee: nobody → Łukasz Zemczak (sil2100)
status: Confirmed → In Progress
Iain Lane (laney) on 2013-10-07
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Łukasz Zemczak (sil2100)
status: Confirmed → In Progress
Łukasz Zemczak (sil2100) wrote :

This bug actually has a deeper problem related. I guess I will try to workaround it simply for now, but I think that in overall we will need a form-factor independent wallpaper asset for the background and just using the default value of gsettings for fallback. Hard-coding fallback images is generally a bad idea, especially that unity8 also has some values hard-coded, but those are done in per-form-factor fashion - i.e. the geometry is checked, and depending on that a different fallback image is used. I will do the same here, but doing a second batch of hardcoding image names is not a good idea generally.

PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-system-settings at revision 448, scheduled for release in ubuntu-system-settings, milestone Unknown

Changed in ubuntu-system-settings:
status: In Progress → Fix Committed
Sebastien Bacher (seb128) wrote :
Changed in ubuntu-system-settings:
status: Fix Committed → Fix Released
Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers