Use Qt::AA_ShareOpenGLContexts and drop Qt private headers usage

[Timo Jyrinki]

Update: Qt 5.4 provides Qt::AA_ShareOpenGLContexts function that should help in dropping the Qt private headers usage in ubuntu-html5-theme, ubuntu-system-settings-online-accounts and webbrowser-app.

More information about Qt 5.4 at: https://wiki.ubuntu.com/Touch/QtTesting

--- original report ---

There's a critical bug that is being fixed with the following MP:

https://code.launchpad.net/~abreu-alexandre/ubuntu-system-settings-online-accounts/use-hw-compositiing-oxide-rtm-1409/+merge/239999

This bug is about removing the need for that, since using private headers causes extra pain for Qt migrations and we should minimize their usage.

Could Oxide provide this somehow else, so that only Oxide would use the private headers (like it already does)?

Update: not blocker for Qt 5.4, but simply something that would help Qt transitions in future by removing 5 packages from the transition list

[David Barth (dbarth)]

+1 this feels like unnecessary technical details, which could be hidden behind an interface or configuration option.

[Timo Jyrinki (timo-jyrinki)]

Adding High priority and qt5.4 tag since the problem seems to be just spreading, latest to ubuntu-html5-theme. All of them are now also broken and need manual patching for Qt 5.4, because all duplicate the same small private headers usage.

[Timo Jyrinki (timo-jyrinki)]

(webbrowser and html5-theme have the necessary #if clause done so far, u-s-s-online-accounts pending)

[Timo Jyrinki (timo-jyrinki)]

And one more update to get the bug off other upstreams' radar for now since they can't do anything about the bug until Oxide provides the functionality.

[Olivier Tilloy (osomon)]

Wouldn’t the newly-introduced (in Qt 5.4) Qt::AA_ShareOpenGLContexts attribute help in that case?

[Chris Coulson (chrisccoulson)]

Having taken a quick glance at the code, it does look like Qt::AA_ShareOpenGLContexts would make this interface in Oxide redundant (Oxide would still need to use a private interface for getting the shared context, but that's ok)

[Timo Jyrinki (timo-jyrinki)]

Should we repurpose this bug so that the other components would use Qt::AA_ShareOpenGLContexts and drop the private headers usage?

[Chris Coulson (chrisccoulson)]

Sounds good. Also means that there isn't anything to do in Oxide

[Launchpad Janitor (janitor)]

This bug was fixed in the package webbrowser-app - 0.23+15.04.20150224-0ubuntu1

---------------
webbrowser-app (0.23+15.04.20150224-0ubuntu1) vivid; urgency=medium

  [ Olivier Tilloy ]
  * Fix a flaky autopilot test. (LP: #1423115)
  * Use Qt::AA_ShareOpenGLContexts when building with Qt >= 5.4. (LP:
    #1387537)

  [ Riccardo Padovani ]
  * Fixed design of multiselection in history view (LP: #1412732)
 -- CI Train Bot <email address hidden> Tue, 24 Feb 2015 10:30:59 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-html5-theme - 0.1.2+15.10.20150520-0ubuntu1

---------------
ubuntu-html5-theme (0.1.2+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Alexandre Abreu ]
  * Fix gallery & component showcase (LP: #1450614)
  * Fix page actions; no need to create actions when none is defined
    (LP: #1455622)
  * Update debian/control to remove qt private package deps; Rely on Qt
    5.4's new API (LP: #1387537)

  [ CI Train Bot ]
  * New rebuild forced.

  [ David Barth ]
  * Add a command line tool to maintain a theme installation in an html5
    project (LP: #1451937)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 16:51:40 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings-online-accounts - 0.6+15.10.20150624-0ubuntu1

---------------
ubuntu-system-settings-online-accounts (0.6+15.10.20150624-0ubuntu1) wily; urgency=medium

  [ Alberto Mardegan ]
  * Fix build with Qt 5.5 (LP: #1387537, #1421009, #1448878, #1447175)
  * Return the error name to the client (LP: #1441873)

  [ CI Train Bot ]
  * New rebuild forced.

 -- CI Train Bot <email address hidden> Wed, 24 Jun 2015 13:36:39 +0000