facebook Oauth provider: 'cancel' button in facebook's web page is ignored

Bug #1231691 reported by Mike McCracken on 2013-09-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Online Accounts setup for Ubuntu Touch
High
Alberto Mardegan
Online Accounts: Sign-on UI
High
Alberto Mardegan
accounts-qml-module
High
Alberto Mardegan
signon-ui (Ubuntu)
Undecided
Unassigned
ubuntu-system-settings-online-accounts (Ubuntu)
Undecided
Unassigned

Bug Description

The cancel button in the facebook oauth login web page doesn't do anything.
(not the cancel button in the QML, but the one in the actual web page facebook serves)

This appears to be specifically facebook - the twitter cancel button changes the page to show you a "go back to ubuntu online accounts" button, which closes the web view and takes you back to the accounts list.

Related branches

Alberto Mardegan (mardy) wrote :

The linked branches add a "Cancel" button in the window containing the WebView, allowing to cancel the creation from there. Also, it seems that changing the user-agent (away from the iPhone one) made the "Cancel" link disappear from the facebook page.

Changed in signon-ui:
assignee: nobody → Alberto Mardegan (mardy)
status: New → In Progress
Changed in ubuntu-system-settings-online-accounts:
status: New → In Progress
Changed in signon-ui:
importance: Undecided → High
Changed in ubuntu-system-settings-online-accounts:
importance: Undecided → High
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-system-settings-online-accounts at revision 57, scheduled for release in ubuntu-system-settings-online-accounts, milestone Unknown

Changed in ubuntu-system-settings-online-accounts:
status: In Progress → Fix Committed
Changed in signon-ui:
status: In Progress → Fix Committed
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:signon-ui at revision 114, scheduled for release in signon-ui, milestone 0.12

Changed in accounts-qml-module:
assignee: nobody → Alberto Mardegan (mardy)
importance: Undecided → High
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:signon-ui at revision 115, scheduled for release in signon-ui, milestone 0.12

Alberto Mardegan (mardy) on 2013-10-09
Changed in accounts-qml-module:
status: New → Invalid
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package signon-ui - 0.15+13.10.20131011-0ubuntu1

---------------
signon-ui (0.15+13.10.20131011-0ubuntu1) saucy; urgency=low

  [ Ken VanDine ]
  * Use a MainView and pull in the UserAgent logic used in the Browser
    component. Using the correct useragent fixes things like facebook
    suggesting users should install the facebook app for iphone (LP:
    #1235259). (LP: #1235259)
  * Allow overriding the QML files used by placing them in
    /usr/share/signon-ui/qml If there is a webview.qml file in that
    directory, load it instead of using the one built into the
    resources. This is useful for debugging QML only changes on the
    device without needing to rebuild and install signon-ui. It is
    important to note, when overriding them you need to copy include the
    .qml and .js files into that directory. .

  [ Iain Lane ]
  * Allow LIBDIR and LIBEXECDIR to be overridden; install in multiarch
    path; set LIBEXECDIR=LIBDIR .

  [ Alberto Mardegan ]
  * Bump build dependency for XEmbed support .
  * Allow the request to be cancelled from the UI. Clients can provide a
    QML component to be used in order to create the authentication page,
    and this gives them a way to add a cancel button there. (LP:
    #1231691)
  * Let the client override the Page component. . (LP: #1231691)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 115
 -- Ubuntu daily release <email address hidden> Fri, 11 Oct 2013 04:33:07 +0000

Changed in signon-ui (Ubuntu):
status: New → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings-online-accounts - 0.2~+13.10.20131011-0ubuntu1

---------------
ubuntu-system-settings-online-accounts (0.2~+13.10.20131011-0ubuntu1) saucy; urgency=low

  [ Ken VanDine ]
  * Put the cancel button in a ListItem to ensure consistent spacing
    with other elements in system-settings.

  [ Andrew Starr-Bochicchio ]
  * Add loading indicator to OAuth page. (LP: #1235004)

  [ Alberto Mardegan ]
  * Delay destruction of the delegate until the edit page is popped Use
    ListView.delayRemove feature to delay the destruction of the
    delegate until we have removed the edit page from the stack. . (LP:
    #1231729)
  * Add a Cancel button to the OAuth authentication pages Use signon-
    ui's new X-PageComponent key to specify a QML page to be used. (LP:
    #1231691)
  * Close the WebView when the authentication is cancelled. (LP:
    #1231680)
  * AccountCreationPage: look for a "flickable" property from the
    plugin. (LP: #1221845)
  * Stop using deprecated gicon image provider .

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 65
 -- Ubuntu daily release <email address hidden> Fri, 11 Oct 2013 08:47:24 +0000

Changed in ubuntu-system-settings-online-accounts (Ubuntu):
status: New → Fix Released
David Barth (dbarth) on 2014-09-22
Changed in ubuntu-system-settings-online-accounts:
status: Fix Committed → Fix Released
Changed in signon-ui:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers