Add D-Bus signal Applied()

Bug #1417176 reported by Barry Warsaw on 2015-02-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu system image
High
Barry Warsaw

Bug Description

In LP: #1381538 we've renamed the 'reboot' hook to 'apply' because there are use cases (such as snappy) where the application of an update does not end in a system reboot.

Along those same lines, the Rebooting() signal is inappropriate in those cases. Instead, we should send an .Applied() signal to indicate that si-dbus has completed its tasks. I think we should deprecate .Rebooting() although I would not remove it for si 3.0. One possibility is to use the default apply hook (e.g. `systemimage.apply.Reboot`) to send the Rebooting() signal but *not* have si normally send Rebooting() but only Applied().

Thus a traditional (i.e. single partition device, e.g. phone) client would get both an Applied() and Rebooting() signal, but a multi-partition device such as snappy would only get the Applied() signal. Of course, on a single partition device, whether a client actually gets Applied and/or Rebooting is still a racy condition since the device may reboot before D-Bus delivers the messages.

Related branches

Barry Warsaw (barry) on 2015-02-03
Changed in ubuntu-system-image:
status: Triaged → In Progress
Barry Warsaw (barry) on 2015-02-05
Changed in ubuntu-system-image:
assignee: nobody → Barry Warsaw (barry)
status: In Progress → Fix Committed
Barry Warsaw (barry) on 2015-05-08
Changed in ubuntu-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers