s-i-dbus should exit on D-Bus method exceptions

Bug #1279970 reported by Barry Warsaw on 2014-02-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu system image
High
Barry Warsaw

Bug Description

When an exception occurs in a D-Bus method or signal, dbus-python prints the traceback to stderr, but then swallows the exception, such that the D-Bus service does not exit. But in D-Bus activation, stderr output is lost for all intents an purposes. Better behavior for us would be to log the exception in the 'systemimage' log file and then exit the s-i-dbus process.

Along with this, I'd like to put more detailed D-Bus logging in a systemimage.dbus logger. This would log enter/exit/exceptions in methods and signals. By default, these would only log at error level, but I will add a config to log at other levels for better debugging.

Related branches

Barry Warsaw (barry) on 2014-05-27
Changed in ubuntu-system-image:
status: New → Triaged
Barry Warsaw (barry) on 2014-05-29
Changed in ubuntu-system-image:
importance: Undecided → Medium
Barry Warsaw (barry) on 2014-08-08
Changed in ubuntu-system-image:
importance: Medium → Low
Barry Warsaw (barry) wrote :

Turns out, I really need this to properly test the fix for LP: #1365646 so I'm bumping the priority up and starting to work on it.

Changed in ubuntu-system-image:
milestone: none → 2.4
status: Triaged → In Progress
importance: Low → High
Barry Warsaw (barry) on 2014-09-11
summary: - Commit suicide earlier, when error case is detected
+ s-i-dbus should exit on D-Bus method exceptions
description: updated
Changed in ubuntu-system-image:
assignee: nobody → Barry Warsaw (barry)
Barry Warsaw (barry) on 2014-09-12
Changed in ubuntu-system-image:
status: In Progress → Fix Committed
Barry Warsaw (barry) on 2014-09-16
Changed in ubuntu-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers