Doesn't switch to wifi when checking for updates and/or doesn't timeout

[Loïc Minier]

Hi there

This is a more advanced use case, so I'd rate this medium severity.

I have trouble with data connection on my phone, I dont think it works at all; I returned home where I have wifi and after a while I tried to get OS updates, which spinned "forever".

First, it should not spin forever if data doesn't work, no idea what the timeout is, but it should be less than 30s (can't download an update sanely if you are not even able to check for an update in 30s).

Then I forced connection to wifi (not sure why it didn't), it remained "checking for updates", I left the OS updates settings panel, and returned to it "checking for updates", forever and ever.

I killed settings, went to OS updates, it was still stuck checking for updates.

So this is probably all resolvable by applying proper timeouts and having a user-level retry option.

There should be network timeouts in the service, and there should be a way to cancel the checks.

I'm open to other suggestions on how to deal with this better, but it seems the only option here is to reboot or perhaps to wait super long for system-image to suicide or for download-manager to timeout.

Cheers,

[Loïc Minier (lool)]

Still an issue with 1.9.1 and latest ubuntu-download-manager:
* pause download
* turn off wifi
* resume download, you get an unreadably long error

Then return to OS updates with network disconnected (no wifi, no 3G), it is stuck in "Checking for updates" seemingly forever; log says:
[systemimage] Oct 16 10:49:33 2013 (2731) uncaught exception in state machine
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/systemimage/state.py", line 138, in run_u
ntil
    step()
  File "/usr/lib/python3/dist-packages/systemimage/state.py", line 249, in _get_
channel
    (asc_url, asc_path),
  File "/usr/lib/python3/dist-packages/systemimage/download.py", line 189, in ge
t_files
    raise FileNotFoundError(self._reactor.error)
FileNotFoundError: https://system-image.ubuntu.com/channels.json:NETWORK ERROR

I guess the process should exit when it gets into a bad state?

[Barry Warsaw (barry)]

I'm going to dup this to LP: #1250817 for the FileNotFoundError handling. As far as the switch to wifi, that's not really something that system-image has anything to do with. It relies on ubuntu-download-manager for handling things at that layer.