_NoUpdate sends buggy UpdateFailed

[Sebastien Bacher]

Using the current version of lp:~barry/ubuntu-system-image/lp1212781, when calling CheckForUpdate() on the mock, there is an UpdateFailed returned before UpdateAvailableStatus, that confuses the system settings client

[Sebastien Bacher (seb128)]

(that's using "system-image-dbus --testing=no-update")

[Barry Warsaw (barry)]

Hmm, I can't reproduce this with r156 lp:~barry/ubuntu-system-image/lp1212781

I made a very minor fix to the no-update mock, but that shouldn't have affected anything. See also test_dbus.py TestDBusMockNoUpdate.test_lp_1215946()

[Sebastien Bacher (seb128)]

no, that's still happening, click the "retry" button in system-settings I get that in dbus-monitor

"signal sender=:1.393 -> dest=(null destination) serial=23 path=/Service; interface=com.canonical.SystemImage; member=UpdateFailed
   int32 5
   string "Canceled"
signal sender=:1.393 -> dest=(null destination) serial=26 path=/Service; interface=com.canonical.SystemImage; member=UpdateAvailableStatus
   boolean false
   boolean false
   string ""
   int32 0
   string "1983-09-13T12:13:14"
   string ""
signal sender=:1.5 -> dest=(null destination) serial=15732 path=/org/freedesktop/NetworkManager/AccessPoint/0; interface=org.freedesktop.NetworkManager.AccessPoint; member=PropertiesChanged
   array [
      dict entry(
         string "Strength"
         variant byte 58
      )
   ]

"

[Sebastien Bacher (seb128)]

(ignore the nm one, copied a bit too much)

[Barry Warsaw (barry)]

Is it possible that the u/i is calling something other than CheckForUpdate() when using the --testing=no-update? That's the only method (and UpdateAvailableStatus is the only signal) that's supported by that testing mode. It will respond to other methods, but you should not count on it. This is true of all the testing modes; they only guarantee the behavior of the use cases defined on the wiki page: https://wiki.ubuntu.com/ImageBasedUpgrades/Client

If that's not the case, please paste the entire dbus dialog with the --testing=no-update server. I can't possibly see any other way this could be happening.

[Barry Warsaw (barry)]

You're getting a residual UpdateFailed probably because you called CancelUpdate.

[Sebastien Bacher (seb128)]

Screenshot of the issue from the duplicate:
https://launchpadlibrarian.net/150384361/device-2013-09-16-090205.png

[Sebastien Bacher (seb128)]

(that's not specific to the mock, updating the title)

the duplicate description states:

"System settings -> About phone -> Check for updates.
If you click the "Retry" button you briefly get a screen blink up which looks like it's about to start downloading, but then goes back to the previous screen with the retry button. The dialog has "download failed: cancelled" in it which is a bit alarming (and erroneous)

It would be a smoother experience if that dialog only appeared if there was actually an update to download.

See screenshot."

[Didier Roche-Tolomelli (didrocks)]

Ok, fixed.

@Barry: I still think that CancelUpdate shouldn't send an UpdateFail signal if there is no transaction in progress though.

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:ubuntu-system-settings at revision 370, scheduled for release in ubuntu-system-settings, milestone Unknown

[Barry Warsaw (barry)]

Re-opened due to comment #9

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.1+13.10.20130925.1-0ubuntu1

---------------
ubuntu-system-settings (0.1+13.10.20130925.1-0ubuntu1) saucy; urgency=low

  [ Ted Gould ]
  * Ask Upstart App Launch to make settings single instance. (LP:
    #1227111)

  [ Iain Lane ]
  * Reduce the height of the time/date pickers as they weren't fitting
    on mobile devices. (LP: #1228409). (LP: #1228409)
  * Use QMenuModel to hook up toggles for bluetooth and gps/location
    enabled/disabled in the battery and security-privacy panels.
    Location is hidden because the backend doesn't work yet.

  [ Lars Uebernickel ]
  * Fix the brightness slider in the battery panel.

  [ Charles Kerr ]
  * Add the bluetooth plugin.

  [ Ken VanDine ]
  * background: Use singleSelect on the transfer request and specify a
    persistent Content::Store for the transfer .

  [ Didier Roche ]
  * Only Cancel if there is anything to cancel. (LP: #1215946)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 378
 -- Ubuntu daily release <email address hidden> Wed, 25 Sep 2013 11:12:19 +0000

[Barry Warsaw (barry)]

Fixed in s-i 1.8.

 * Only send the `UpdateFailed` signal in response to a `CancelUpdate()` call
   if a download is already in progress. No signal is sent if there's no
   download in progress. Getting the files to determine whether an update is
   available or not does not count as a "download in progress". (LP: #1215946)

[Didier Roche-Tolomelli (didrocks)]

Rocking!