On windows, syncdaemon can't be stopped.
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Client |
Invalid
|
High
|
Alejandro J. Cura | |||
Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
Trunk |
Fix Released
|
High
|
Alejandro J. Cura |
Bug Description
If you start syncdaemon, and then try to stop it using "u1sdtool -q" or u1cp's tray context menu, it will not stop. Here's the output from syncdaemon:
2012-03-23 16:26:31,693 - twisted - ERROR - Failure: twisted.
Failure: twisted.
<class 'twisted.
2012-03-23 16:26:31,694 - twisted - ERROR - ]
]
2012-03-23 16:26:31,696 - twisted - ERROR - *--- End of Failure #29 ---
*--- End of Failure #29 ---
2012-03-23 16:26:31,697 - ubuntuone.
None
2012-03-23 16:26:31,698 - twisted - INFO - Stopping factory <twisted.
2012-03-23 16:26:31,704 - twisted - INFO - Main loop terminated.
This is a problem because syncdaemon is closing the IPC port but not closing its logs, so the next attempt to use it will activate a new instance, which will fail catastrophically with "I/O in closed file" errors because it can't log.
Related branches
- Diego Sarmentero (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 81 lines (+6/-9)2 files modifiedubuntu_sso/networkstate/tests/test_windows.py (+4/-7)
ubuntu_sso/networkstate/windows.py (+2/-2)
- Alejandro J. Cura (community): Approve
-
Diff: 548 lines (+341/-13)12 files modifieddata/qt/stylesheet.qss (+4/-1)
ubuntu_sso/keyring/windows.py (+1/-1)
ubuntu_sso/networkstate/tests/test_windows.py (+4/-7)
ubuntu_sso/networkstate/windows.py (+2/-2)
ubuntu_sso/utils/runner/qt.py (+7/-0)
ubuntu_sso/utils/runner/tests/test_qt.py (+19/-0)
ubuntu_sso/utils/tests/test_windows.py (+65/-0)
ubuntu_sso/utils/webclient/gsettings.py (+8/-1)
ubuntu_sso/utils/webclient/qtnetwork.py (+8/-1)
ubuntu_sso/utils/webclient/tests/test_gsettings.py (+23/-0)
ubuntu_sso/utils/webclient/tests/test_qtnetwork.py (+157/-0)
ubuntu_sso/utils/windows.py (+43/-0)
Changed in ubuntu-sso-client: | |
status: | Triaged → Fix Committed |
This is a problem with the network state detection code imported from Ubuntu SSO Client.
The NetworkManagerState class in windows creates a thread, and it never gets stopped.