Titling labels have redundant tooltips
Bug #949741 reported by
Adolfo Jayme Barrientos
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
Trunk |
Fix Released
|
Medium
|
Natalia Bidart | |||
ubuntu-sso-client (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When you hover the "Sign In to Ubuntu One" and "To connect this computer to Ubuntu One enter your details below" labels, an unnecesary tooltip appear, repeating the same text in the labels. This is incorrect because the tooltips do not offer any new information, and in any case, labels with tooltips are weird.
Related branches
lp:~nataliabidart/ubuntu-sso-client/reusable-headers
- Diego Sarmentero (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 1257 lines (+391/-267)19 files modifieddata/qt/stylesheet.qss (+1/-7)
run-tests (+1/-1)
ubuntu_sso/qt/__init__.py (+26/-2)
ubuntu_sso/qt/current_user_sign_in_page.py (+4/-6)
ubuntu_sso/qt/email_verification_page.py (+1/-1)
ubuntu_sso/qt/forgotten_password_page.py (+1/-1)
ubuntu_sso/qt/reset_password_page.py (+1/-1)
ubuntu_sso/qt/setup_account_page.py (+5/-5)
ubuntu_sso/qt/sso_wizard_page.py (+101/-75)
ubuntu_sso/qt/tests/__init__.py (+54/-6)
ubuntu_sso/qt/tests/test_common.py (+49/-2)
ubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+4/-4)
ubuntu_sso/qt/tests/test_email_verification.py (+6/-7)
ubuntu_sso/qt/tests/test_forgotten_password.py (+3/-2)
ubuntu_sso/qt/tests/test_loadingoverlay.py (+0/-3)
ubuntu_sso/qt/tests/test_reset_password.py (+4/-14)
ubuntu_sso/qt/tests/test_setup_account.py (+36/-65)
ubuntu_sso/qt/tests/test_sso_wizard_page.py (+88/-59)
ubuntu_sso/qt/tests/test_ubuntu_sso_wizard.py (+6/-6)
lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.91
- Roberto Alsina (community): Approve
-
Diff: 5121 lines (+2191/-925)62 files modifiedbin/ubuntu-sso-login-qt (+6/-3)
bin/ubuntu-sso-proxy-creds-qt (+6/-3)
data/qt/linux.qss (+2/-0)
data/qt/loadingoverlay.ui (+0/-5)
data/qt/proxy_credentials_dialog.ui (+0/-2)
data/qt/reset_password.ui (+199/-262)
data/qt/resources.qrc (+2/-0)
data/qt/setup_account.ui (+1/-36)
data/qt/ssl_dialog.ui (+0/-5)
data/qt/stylesheet.qss (+1/-13)
data/qt/windows.qss (+5/-0)
po/POTFILES.in (+1/-0)
run-tests (+1/-1)
ubuntu_sso/__init__.py (+8/-0)
ubuntu_sso/gtk/gui.py (+18/-33)
ubuntu_sso/gtk/tests/test_gui.py (+34/-5)
ubuntu_sso/qt/__init__.py (+33/-5)
ubuntu_sso/qt/common.py (+3/-3)
ubuntu_sso/qt/current_user_sign_in_page.py (+13/-12)
ubuntu_sso/qt/email_verification_page.py (+8/-5)
ubuntu_sso/qt/enhanced_check_box.py (+9/-3)
ubuntu_sso/qt/forgotten_password_page.py (+5/-1)
ubuntu_sso/qt/loadingoverlay.py (+3/-1)
ubuntu_sso/qt/main.py (+12/-3)
ubuntu_sso/qt/network_detection_page.py (+5/-1)
ubuntu_sso/qt/proxy_dialog.py (+4/-7)
ubuntu_sso/qt/reset_password_page.py (+6/-2)
ubuntu_sso/qt/setup_account_page.py (+19/-18)
ubuntu_sso/qt/sso_wizard_page.py (+116/-76)
ubuntu_sso/qt/tests/__init__.py (+55/-7)
ubuntu_sso/qt/tests/login_u_p.py (+0/-2)
ubuntu_sso/qt/tests/show_gui.py (+0/-2)
ubuntu_sso/qt/tests/test_common.py (+130/-2)
ubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+28/-17)
ubuntu_sso/qt/tests/test_email_verification.py (+6/-7)
ubuntu_sso/qt/tests/test_enhanced_check_box.py (+19/-1)
ubuntu_sso/qt/tests/test_forgotten_password.py (+6/-4)
ubuntu_sso/qt/tests/test_loadingoverlay.py (+0/-3)
ubuntu_sso/qt/tests/test_main.py (+108/-12)
ubuntu_sso/qt/tests/test_proxy_dialog.py (+2/-2)
ubuntu_sso/qt/tests/test_reset_password.py (+9/-17)
ubuntu_sso/qt/tests/test_setup_account.py (+55/-71)
ubuntu_sso/qt/tests/test_ssl_dialog.py (+2/-1)
ubuntu_sso/qt/tests/test_sso_wizard_page.py (+98/-59)
ubuntu_sso/qt/tests/test_ubuntu_sso_wizard.py (+36/-6)
ubuntu_sso/qt/ubuntu_sso_wizard.py (+19/-2)
ubuntu_sso/utils/__init__.py (+15/-2)
ubuntu_sso/utils/linux.py (+19/-0)
ubuntu_sso/utils/runner/glib.py (+1/-1)
ubuntu_sso/utils/runner/tx.py (+1/-1)
ubuntu_sso/utils/tests/test_common.py (+10/-1)
ubuntu_sso/utils/ui.py (+7/-1)
ubuntu_sso/utils/webclient/__init__.py (+18/-2)
ubuntu_sso/utils/webclient/common.py (+110/-2)
ubuntu_sso/utils/webclient/gsettings.py (+21/-14)
ubuntu_sso/utils/webclient/libsoup.py (+48/-4)
ubuntu_sso/utils/webclient/qtnetwork.py (+124/-22)
ubuntu_sso/utils/webclient/tests/__init__.py (+74/-6)
ubuntu_sso/utils/webclient/tests/test_gsettings.py (+44/-61)
ubuntu_sso/utils/webclient/tests/test_webclient.py (+510/-10)
ubuntu_sso/utils/webclient/txweb.py (+77/-78)
ubuntu_sso/utils/windows.py (+19/-0)
Changed in ubuntu-sso-client: | |
assignee: | nobody → Natalia Bidart (nataliabidart) |
status: | New → In Progress |
importance: | Undecided → Medium |
Changed in ubuntu-sso-client: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
This bug was fixed in the package ubuntu-sso-client - 2.99.91-0ubuntu1
---------------
ubuntu-sso-client (2.99.91-0ubuntu1) precise; urgency=low
* New upstream release: general_ error_message is not a dict (LP: #865176). email_verificat ion_page wasn't receiving the params SETUP_LATER button text anager (LP: #957313). tionRequired to avoid the
- Do not allow ssl errors to be ignored (LP: #959390).
- Handle wrong credentials properly in qtnetwork webclient
(LP: #957317).
- Use HTTPClientFactory to allow replacing the reactor used to connect
(LP: #929207).
- Decode the content of help_text (LP: #951371).
- Adding missing file for translation (LP: #951376).
- Adding a general error message when the argument received by
build_
- Adding some checks to setup_page (LP: #951461).
- Adding a padding to the right margin of the reset layout, and align
one of its layout to the left (LP: #945065).
- Executing hide_error when the user click the refresh captcha link,
not inside of the _refresh_captcha method, because this is executed
automatically when a captcha error is generated, so we will always
miss the error message (LP: #955010).
- Removing the align property from the label that wasn't necessary
and was breakint the work wrap. Also adjust the height of the widget
depending if it has more than one line (LP: #940392).
- Improve logging operations (LP: #934500).
- Making LINK_STYLE to be unicode (LP: #950953).
- Setting the window title equal to the app_name (LP: #949744).
- The _move_to_
that the signal emits (LP: #945066).
- Improve the grammar for the CLOSE_AND_
(LP: #949978).
- Changed the way in which we deal with proxies to work around bugs
found in the QNetworkAccessM
- Stopped listening to the proxyAuthentica
dialog showing more than once (LP: #957170)
- Made changes in the way the webclient is selected to ensure that qt
is used when possible (LP: #957169).
- Connected the WebKit browser correctly so that the tc page gets
loaded (LP: #933081).
- Added code to check if the browser with the t&c was already loaded.
If it is just show the t&c page, otherwise perform the request
(LP: #956185).
- Added a translatable string to give more context of the ssl cert
info to the user (LP: #948119).
- Provided the logic required for the Qt webclient implementation to
detect ssl errors and spawn the ssl dialog to allow the user accept
the ssl cert exceptions (LP: #948134).
- Changed the qt webclient implementation to use a proxy factory so
that the correct proxy is chosen according to the request
(LP: #950088).
- Added the required code to allow the webclient use authenticated
proxies and request the creds when needed (LP: #933727).
- The tooltip should not be shown for titles and subtitles when
no cut off was needed (LP: #949741).
- Enable platform-specific styling (LP: #953318).
- Only import DBus on Linux (LP: #956304).
- Don't hard-code font sizes.
- Remove usage of weight property as a numeric; just use...