Qt UI: when calling login or validate_email, should pass the ping_url

Bug #930724 reported by Natalia Bidart on 2012-02-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Single Sign On Client
Status tracked in Trunk
Stable-3-0
Undecided
Unassigned
Trunk
Critical
Diego Sarmentero

Bug Description

In order for the ping to happen if a ping_url was provided, we need to make the Qt UI pass that params, if available, to the backend.

For reference, please look at the Gtk implementation. For example, it has:

ubuntu_sso/gtk/gui.py:815

    815 args = (self.app_name, email, password, email_token)
    816 if self.ping_url:
    817 f = self.backend.validate_email_and_ping
    818 args = args + (self.ping_url,)
    819 else:
    820 f = self.backend.validate_email
    821
    822 logger.info('Calling validate_email with email %r, password <hidden>, '
    823 'app_name %r and email_token %r.', email, self.app_name,
    824 email_token)
    825 error_handler = partial(self._handle_error, f,
    826 self.on_email_validation_error)
    827 f(*args, reply_handler=NO_OP, error_handler=error_handler)

(do the same for the login call).

Related branches

Changed in ubuntu-sso-client:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Diego Sarmentero (diegosarmentero)
Changed in ubuntu-sso-client:
status: Triaged → In Progress
Changed in ubuntu-sso-client:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers