The common webclient should be able to handle urls that are unicode and not str
Bug #911844 reported by
Manuel de la Peña
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
| Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Undecided
|
Alejandro J. Cura | |||
Bug Description
The url within SSO is handled as a unicode and therefore the methods from the webclient should do url = url.encode('utf-8') just before performing the actual request in the different implementations rather than expecting the rest of the code take care of it.
Related branches
lp:~alecu/ubuntu-sso-client/proxy-integration-tests
- Manuel de la Peña (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 726 lines (+419/-30)8 files modifiedubuntu_sso/utils/webclient/common.py (+14/-3)
ubuntu_sso/utils/webclient/gsettings.py (+63/-0)
ubuntu_sso/utils/webclient/libsoup.py (+32/-4)
ubuntu_sso/utils/webclient/qtnetwork.py (+32/-4)
ubuntu_sso/utils/webclient/tests/test_gsettings.py (+131/-0)
ubuntu_sso/utils/webclient/tests/test_webclient.py (+88/-16)
ubuntu_sso/utils/webclient/tests/webclient_demo.py (+51/-0)
ubuntu_sso/utils/webclient/txweb.py (+8/-3)
lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.2
- dobey (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 8787 lines (+3936/-3449)37 files modifiedubuntu_sso/account.py (+11/-14)
ubuntu_sso/credentials.py (+61/-25)
ubuntu_sso/logger.py (+20/-0)
ubuntu_sso/main/__init__.py (+257/-111)
ubuntu_sso/main/linux.py (+181/-164)
ubuntu_sso/main/tests/__init__.py (+37/-0)
ubuntu_sso/main/tests/test_clients.py (+373/-0)
ubuntu_sso/main/tests/test_common.py (+911/-155)
ubuntu_sso/main/tests/test_linux.py (+0/-1275)
ubuntu_sso/main/tests/test_windows.py (+18/-926)
ubuntu_sso/main/windows.py (+185/-663)
ubuntu_sso/networkstate/__init__.py (+8/-0)
ubuntu_sso/networkstate/linux.py (+24/-0)
ubuntu_sso/networkstate/tests/test_linux.py (+137/-2)
ubuntu_sso/networkstate/tests/test_windows.py (+64/-0)
ubuntu_sso/networkstate/windows.py (+13/-5)
ubuntu_sso/qt/controllers.py (+12/-3)
ubuntu_sso/qt/tests/__init__.py (+7/-4)
ubuntu_sso/qt/tests/login_u_p.py (+37/-29)
ubuntu_sso/qt/tests/show_gui.py (+36/-20)
ubuntu_sso/qt/tests/test_controllers.py (+0/-2)
ubuntu_sso/tests/__init__.py (+41/-0)
ubuntu_sso/tests/test_account.py (+17/-3)
ubuntu_sso/tests/test_credentials.py (+11/-14)
ubuntu_sso/utils/ipc.py (+361/-0)
ubuntu_sso/utils/tests/test_common.py (+5/-1)
ubuntu_sso/utils/tests/test_ipc.py (+505/-0)
ubuntu_sso/utils/tests/test_txsecrets.py (+22/-0)
ubuntu_sso/utils/webclient/common.py (+16/-4)
ubuntu_sso/utils/webclient/gsettings.py (+63/-0)
ubuntu_sso/utils/webclient/libsoup.py (+32/-4)
ubuntu_sso/utils/webclient/qtnetwork.py (+36/-6)
ubuntu_sso/utils/webclient/restful.py (+52/-0)
ubuntu_sso/utils/webclient/tests/test_gsettings.py (+131/-0)
ubuntu_sso/utils/webclient/tests/test_restful.py (+148/-0)
ubuntu_sso/utils/webclient/tests/test_webclient.py (+96/-16)
ubuntu_sso/utils/webclient/txweb.py (+8/-3)
| summary: |
- Teh common webclient should be able to handle urls that are unicode and + The common webclient should be able to handle urls that are unicode and not str |
| Changed in ubuntu-sso-client: | |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| status: | New → In Progress |
| Changed in ubuntu-sso-client: | |
| milestone: | none → 2.99.2 |
To post a comment you must log in.
