[Browser] iframe doesn't display anything when a load fails

Bug #1338180 reported by Adnane Belmadiaf
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Triaged
Medium
Unassigned
Ubuntu UX
Triaged
Medium
James Mulholland
webbrowser-app (Ubuntu)
Confirmed
Medium
Unassigned

Bug Description

Revision history for this message
Adnane Belmadiaf (daker) wrote :
Revision history for this message
Adnane Belmadiaf (daker) wrote :
Revision history for this message
Adnane Belmadiaf (daker) wrote :
Olivier Tilloy (osomon)
Changed in webbrowser-app:
importance: Undecided → Medium
status: New → Confirmed
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
Changed in webbrowser-app (Ubuntu RTM):
status: New → Confirmed
Changed in webbrowser-app (Ubuntu):
importance: Undecided → Medium
Changed in webbrowser-app (Ubuntu RTM):
importance: Undecided → Medium
Changed in webbrowser-app:
status: Confirmed → Invalid
summary: - Iframe with a 404 status doesn't return anything
+ Iframe with a 404 status doesn't display anything
summary: - Iframe with a 404 status doesn't display anything
+ iframe with a 404 status doesn't display anything
Revision history for this message
Chris Coulson (chrisccoulson) wrote : Re: iframe doesn't display anything when a load fails

I've changed the title - if we get a 404 response, the frame will display the response from the server. In this case, the load fails (there is no 404).

I guess this is the downside of having the error page as part of the browser UI :/

summary: - iframe with a 404 status doesn't display anything
+ iframe doesn't display anything when a load fails
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

So the only way to fix this is to implement the error page as HTML, and have Oxide render that in the right frame.

Olivier, how easy would it be to implement the error page in HTML if I provide a mechanism to allow Oxide to display it?

Revision history for this message
Adnane Belmadiaf (daker) wrote :

i guess it's also a matter of i18n the error page content, handling the size of assets depending on the screen, i think this is how it's done in Chrome/ium

https://chromium.googlesource.com/chromium/src/+/master/chrome/renderer/resources/neterror.html
https://chromium.googlesource.com/chromium/src/+/master/chrome/renderer/resources/neterror.js

Revision history for this message
Olivier Tilloy (osomon) wrote :

Chris, the current design only requires the page to have a reload button, so implementing it in HTML would be trivial.
As Adnane points out, we’ll need to internationalize the contents. We can probably generate the page dynamically, or generate static pages for each available translation at build time. What would the API for defining the error page look like?

no longer affects: webbrowser-app
no longer affects: webbrowser-app (Ubuntu RTM)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Added an ubuntu-ux task to get input from design: we might want to consider displaying a slightly different error page when in an iframe, as opposed to the main frame.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I don't know what an API would look like yet, as this lives on the renderer side. Generating content dynamically and handling localizations isn't a problem though - Chrome uses the same mechanism

Changed in oxide:
importance: Undecided → Medium
status: New → Triaged
John Lea (johnlea)
summary: - iframe doesn't display anything when a load fails
+ [Browser] iframe doesn't display anything when a load fails
Changed in ubuntu-ux:
assignee: nobody → James Mulholland (jamesjosephmulholland)
importance: Undecided → Medium
Changed in ubuntu-ux:
status: New → Triaged
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

So, the fix for this is that the error page will be implemented in HTML and live in the new UbuntuWebView implementation inside Oxide.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.