"Revealed Indicators" UI hides some indicators
Bug #1382078 reported by
Charles Kerr
on 2014-10-16
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | unity8 (Ubuntu) |
Undecided
|
Unassigned | ||
| | unity8 (Ubuntu RTM) |
Undecided
|
Unassigned | ||
Bug Description
The new indicator panel code (correctly) honors the indicators' "visible" flag when deciding what to hide from the status bar.
However, it also (incorrectly) honors this flag in the Revealed Indicators UI. The RTM Usability Fixes document lists that all of our indicators should be visible there, regardless of whether they're hidden in the status bar.
IIUC this was one of the original goals of the redesign -- to declutter the status bar without losing access to the lesser indicators
Related branches
lp:~nick-dedekind/unity8/expanded-panel-design
- Michael Terry: Approve on 2014-10-21
- PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2014-10-21
- Daniel d'Andrada (community): Abstain on 2014-10-14
- Michał Sawicz: Needs Fixing on 2014-10-14
- Albert Astals Cid (community): Abstain on 2014-10-14
- Andrea Cimitan (community): Needs Fixing on 2014-10-08
- Nick Dedekind (community): Needs Fixing on 2014-10-07
- Omer Akram: Pending (functional) requested 2014-10-03
-
Diff: 5736 lines (+2171/-2135)56 files modifiedplugins/Unity/Indicators/Indicators.qmltypes (+2/-4)
plugins/Unity/Indicators/indicators.h (+0/-2)
plugins/Unity/Indicators/indicatorsmodel.cpp (+0/-6)
plugins/Unity/Indicators/rootactionstate.cpp (+1/-1)
plugins/Unity/Indicators/rootactionstate.h (+4/-4)
plugins/Unity/Indicators/sharedunitymenumodel.cpp (+6/-1)
plugins/Unity/Indicators/unitymenumodelcache.cpp (+1/-5)
plugins/Unity/Indicators/unitymenumodelcache.h (+1/-3)
plugins/Unity/Indicators/visibleindicatorsmodel.cpp (+0/-2)
qml/Components/DragHandle.qml (+6/-1)
qml/Components/EdgeDemo.qml (+13/-10)
qml/Components/ListItems/VerticalThinDivider.qml (+0/-26)
qml/Components/ScrollCalculator.qml (+81/-0)
qml/Panel/Handle.qml (+43/-0)
qml/Panel/IndicatorItem.qml (+0/-53)
qml/Panel/IndicatorItemRow.qml (+297/-0)
qml/Panel/IndicatorPage.qml (+10/-16)
qml/Panel/IndicatorRow.qml (+0/-163)
qml/Panel/Indicators.qml (+0/-415)
qml/Panel/Indicators/DefaultIndicatorWidget.qml (+0/-119)
qml/Panel/Indicators/IndicatorBase.qml (+1/-5)
qml/Panel/Indicators/IndicatorDelegate.qml (+2/-2)
qml/Panel/Indicators/VisibleIndicators.qml (+4/-5)
qml/Panel/Indicators/client/IndicatorRepresentation.qml (+22/-11)
qml/Panel/Indicators/client/IndicatorsList.qml (+2/-2)
qml/Panel/Indicators/client/IndicatorsTree.qml (+4/-26)
qml/Panel/IndicatorsBar.qml (+269/-0)
qml/Panel/IndicatorsMenu.qml (+318/-0)
qml/Panel/MenuContent.qml (+26/-83)
qml/Panel/Panel.qml (+0/-191)
qml/Panel/PanelVelocityCalculator.qml (+54/-0)
qml/Shell.qml (+16/-5)
tests/autopilot/unity8/indicators/tests/test_indicators.py (+1/-1)
tests/autopilot/unity8/shell/emulators/main_window.py (+6/-6)
tests/mocks/Unity/Indicators/Indicators.qmltypes (+2/-4)
tests/mocks/Unity/Indicators/IndicatorsModel.qml (+89/-79)
tests/mocks/Unity/Indicators/RootActionState.qml (+2/-2)
tests/mocks/Unity/Indicators/fakeindicatorsmodel.cpp (+0/-2)
tests/mocks/Unity/Indicators/fakeunitymenumodelcache.cpp (+10/-8)
tests/mocks/Unity/Indicators/fakeunitymenumodelcache.h (+4/-8)
tests/qmltests/CMakeLists.txt (+5/-5)
tests/qmltests/Greeter/tst_Clock.qml (+1/-3)
tests/qmltests/Panel/IndicatorTest.qml (+80/-0)
tests/qmltests/Panel/Indicators/tst_DefaultIndicatorWidget.qml (+0/-52)
tests/qmltests/Panel/tst_ActiveCallHint.qml (+0/-1)
tests/qmltests/Panel/tst_IndicatorItem.qml (+0/-50)
tests/qmltests/Panel/tst_IndicatorItemRow.qml (+290/-0)
tests/qmltests/Panel/tst_IndicatorPage.qml (+5/-7)
tests/qmltests/Panel/tst_IndicatorRow.qml (+0/-158)
tests/qmltests/Panel/tst_Indicators.qml (+0/-231)
tests/qmltests/Panel/tst_IndicatorsBar.qml (+224/-0)
tests/qmltests/Panel/tst_IndicatorsMenu.qml (+258/-0)
tests/qmltests/Panel/tst_MenuContent.qml (+9/-17)
tests/qmltests/Panel/tst_Panel.qml (+0/-337)
tests/qmltests/Panel/tst_SearchIndicator.qml (+0/-1)
tests/qmltests/tst_Shell.qml (+2/-2)
Charles Kerr (charlesk)
on 2014-10-16
| summary: |
- new indicator panel code hides some indicators + "Revealed Indicators" UI hides some indicators |
| description: | updated |
| description: | updated |
Nick Dedekind (nick-dedekind)
on 2014-10-16
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Nick Dedekind (nick-dedekind) |
| status: | New → Incomplete |
| status: | Incomplete → Confirmed |
Nick Dedekind (nick-dedekind)
on 2014-10-20
| Changed in unity8 (Ubuntu): | |
| status: | Confirmed → In Progress |
| Changed in unity8 (Ubuntu RTM): | |
| status: | New → In Progress |
| assignee: | nobody → Nick Dedekind (nick-dedekind) |
Nick Dedekind (nick-dedekind)
on 2014-11-12
| Changed in unity8 (Ubuntu): | |
| status: | In Progress → Fix Released |
Grant Slater (firefishy)
on 2020-10-09
| Changed in unity8 (Ubuntu RTM): | |
| assignee: | Nick Dedekind (nick-dedekind) → nobody |
| Changed in unity8 (Ubuntu): | |
| assignee: | Nick Dedekind (nick-dedekind) → nobody |
To post a comment you must log in.
