Ubuntu RTM
ubuntu-ui-toolkit package

[regression] Missing clear-search icon

Bug #1531584 reported by Michael Terry
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Critical
Zoltan Balogh
Canonical System Image ww02-2016 "ota9"
ubuntu-ui-toolkit (Ubuntu RTM)
Fix Released
Undecided
Cris Dywan

Bug Description

In rc-proposed, there is no longer a "clear-search" icon. Several apps reference it (like uReddit and webbrowser-app) and now they show no icon where it would be (usually a search box).

Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
assignee: nobody → Zoltan Balogh (bzoltan)
importance: Undecided → Critical
milestone: none → ww02-2016
status: New → Confirmed
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

This change to TextField.qml looks suspicious:

700 - name: control.hasClearButton && !control.readOnly ? "clear-search" : ""
701 + name: control.hasClearButton && !control.readOnly ? "edit-clear" : ""

Jean-Baptiste Lallement (jibel)
tags: added: regression-proposed
Revision history for this message
Tim Peeters (tpeeters) wrote :

That change was made in this MR: https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/validClearIconName/+merge/280968

Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Christian Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
assignee: nobody → Christian Dywan (kalikiana)
Revision history for this message
Michael Terry (mterry) wrote :

OK, so that MR mentions that clear-search is suru-specific, and there's a more standard "edit-clear" that should be used. So that MP seems harmless / correct.

But someone went one step further and removed clear-search from suru it seems. Even though apps are still using it.

Zoltan Balogh (bzoltan)
no longer affects: ubuntu-ui-toolkit (Ubuntu)
Revision history for this message
Zoltan Balogh (bzoltan) wrote :

http://picpaste.com/pics/foo-vEeQlRsE.1452152411.png
http://picpaste.com/pics/messaging-Q6Ggp6MF.1452152305.png
http://picpaste.com/pics/contacts-K5QLar2M.1452152383.png

With UITK rev 1.3.1795+15.04.20160106-0ubuntu1 from image rev 223 there is no problem with the clear icon.

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: New → Invalid
Changed in canonical-devices-system-image:
status: Confirmed → Fix Released
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: Invalid → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.