[sdk] Use icon from theme for toggles and optionselector
Bug #1372582 reported by
Tim Peeters
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UI Toolkit |
Fix Released
|
Medium
|
Tim Peeters | ||
| Ubuntu UX |
Fix Released
|
Low
|
Jouni Helminen | ||
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Vivid |
Fix Released
|
Undecided
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu RTM) |
New
|
Undecided
|
Unassigned | ||
Bug Description
The checkmark can be used from the icon theme instead of an included png file
Related branches
lp:~tpeeters/ubuntu-ui-toolkit/littleSwitch
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 260 lines (+133/-44)2 files modifiedmodules/Ubuntu/Components/Themes/Ambiance/SwitchStyle.qml (+132/-43)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+1/-1)
lp:~tpeeters/ubuntu-ui-toolkit/check
- Cris Dywan: Approve
- PS Jenkins bot: Approve (continuous-integration)
- Jouni Helminen (community): Approve
-
Diff: 256 lines (+123/-91)2 files modifiedmodules/Ubuntu/Components/Themes/Ambiance/CheckBoxStyle.qml (+122/-90)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+1/-1)
| Changed in ubuntu-ui-toolkit: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| assignee: | nobody → Tim Peeters (tpeeters) |
| tags: | added: design-sync |
| Changed in ubuntu-ui-toolkit: | |
| status: | Confirmed → New |
| Changed in ubuntu-ux: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| assignee: | nobody → Jouni Helminen (jounihelminen) |
| tags: | added: ota-2 |
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Confirmed |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | Tim Peeters (tpeeters) → Christian Dywan (kalikiana) |
| status: | Confirmed → In Progress |
Revision history for this message
| Cris Dywan (kalikiana) wrote | #1 |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | Christian Dywan (kalikiana) → nobody |
| status: | In Progress → Confirmed |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | nobody → Tim Peeters (tpeeters) |
| Changed in ubuntu-ui-toolkit: | |
| status: | Confirmed → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #2 |
| Changed in ubuntu-ui-toolkit: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in ubuntu-ui-toolkit: | |
| status: | Fix Committed → Fix Released |
| summary: |
- Use icon from theme for toggles and optionselector + [sdk] Use icon from theme for toggles and optionselector |
| Changed in ubuntu-ux: | |
| status: | Triaged → Fix Released |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → Fix Released |
| Changed in ubuntu-ui-toolkit (Ubuntu Vivid): | |
| status: | New → Fix Released |
To post a comment you must log in.
It looks like it's more involved than I anticipated; using the icons straight not only requires re-thinking the code but the themed icons don't seem have the same margins and end up looking different.