Phone number highlighting is not localized

Bug #1376803 reported by Víctor R. Ruiz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Bill Filler
messaging-app
Fix Released
High
Alexandre Abreu
messaging-app (Ubuntu)
Fix Released
High
Alexandre Abreu
messaging-app (Ubuntu RTM)
Fix Released
High
Gustavo Pichorim Boiko
telephony-service (Ubuntu)
Fix Released
High
Unassigned
telephony-service (Ubuntu RTM)
In Progress
Undecided
Gustavo Pichorim Boiko

Bug Description

Test plan has a case to "Receive an sms that has a phone number in it". Test case passes, but only if the number has a US (I guess) format, that is 617-688-0034. Spanish phone numbers like "666.777.888" or "666554433" aren't highlighted.

Related branches

Víctor R. Ruiz (vrruiz)
summary: - Phone number highlighting issues
+ Phone number highlighting is not localized
Revision history for this message
Bill Filler (bfiller) wrote :

I don't understand what is supposed to be highlighted? What is the use case that is not working?

Changed in messaging-app:
status: New → Incomplete
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Bill: If the phone number has an specific format, it is "linked" (as in HTML), so you can tap on it in order to start a call. That format is not localized, so usual phone numbers in Spain (or in other countries) don't get "linked" (or "highlighted").

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

I ran into this issue (or something close enough) while dog fooding the phone, so I MRd some branches that ought to strengthen the phone number detection (that was failing in my case) and also cover this bug,

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Those also fix issues around false positives (that I have quite a bit in my case) when processing the message texts to tel://

Bill Filler (bfiller)
Changed in messaging-app:
status: Incomplete → In Progress
importance: Undecided → High
assignee: nobody → Alexandre Abreu (abreu-alexandre)
Changed in messaging-app (Ubuntu):
importance: Undecided → High
Changed in messaging-app (Ubuntu RTM):
importance: Undecided → High
Changed in messaging-app (Ubuntu):
status: New → In Progress
assignee: nobody → Alexandre Abreu (abreu-alexandre)
Bill Filler (bfiller)
Changed in telephony-service (Ubuntu):
importance: Undecided → High
tags: added: ww03
Bill Filler (bfiller)
tags: added: ww07
removed: ww03
Changed in messaging-app (Ubuntu):
status: In Progress → Fix Released
Changed in telephony-service (Ubuntu):
status: New → Fix Released
Changed in messaging-app (Ubuntu RTM):
status: New → In Progress
assignee: nobody → Gustavo Pichorim Boiko (boiko)
Changed in telephony-service (Ubuntu RTM):
status: New → In Progress
assignee: nobody → Gustavo Pichorim Boiko (boiko)
Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww07-2015
status: New → In Progress
Changed in canonical-devices-system-image:
assignee: nobody → Bill Filler (bfiller)
milestone: ww07-2015 → ww09-2015
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package messaging-app - 0.1+15.04.20150212~rtm-0ubuntu1

---------------
messaging-app (0.1+15.04.20150212~rtm-0ubuntu1) 14.09; urgency=medium

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Gustavo Pichorim Boiko ]
  * Localize and strengthen the phone number detection scheme used from
    within a given message bubble as it is replaced by tel:// URIs. (LP:
    #1376803, #1391183)

  [ Tiago Salem Herrmann ]
  * Disable spinner for incoming messages. (LP: #1420976)
 -- Ubuntu daily release <email address hidden> Thu, 12 Feb 2015 00:16:39 +0000

Changed in messaging-app (Ubuntu RTM):
status: In Progress → Fix Released
Changed in canonical-devices-system-image:
status: In Progress → Fix Released
Changed in messaging-app:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.