test-call-forwarding script is broken

[Tony Espy]

channel: ubuntu-touch/ubuntu-rtm/14.09-proposed
image: #167
device: all

The ofono script 'test-call-forwarding' has multiple errors that prevent it from being run.

First, when run, Python3 complains about mixed tabs and spaces.

Second, when run, the code fails with an error with the argument parsing code. This looks to syntax errors with the following statement:

if (args.modem == "")

[Tony Espy (awe)]

Proposed fix:

https://github.com/rilmodem/ofono/pull/133

[Launchpad Janitor (janitor)]

This bug was fixed in the package ofono - 1.12.bzr6886+15.04.20150204-0ubuntu1

---------------
ofono (1.12.bzr6886+15.04.20150204-0ubuntu1) vivid; urgency=medium

  [ Tony Espy ]
  * test/rilmodem/sim: add new SIM test scripts
  * test: fix test-call-forwarding script (LP: #1396323)

  [ Vicamo Yang ]
  * mtkmodem, rilmodem: re-factor naming
    This change makes the naming of GRil, mtk_data,
    ofono_modem, and ril_data instances consistent.
  * rilmodem: fix duplicate APPSTATE* constants
  * gril: get rid of duplicate ringbuffer.h (LP: #1408250)
  * mtk.c: use RIL_RADIO_POWER request for single slot modems

  [ Alfonso Sanchez-Beato ]
  * gril, unit, mtk.c: SIM mode and session ID fixes for arale
    For MTK modems, DUAL_SIM_MODE requests aren't necessary. Also
    add session-id to SIM IO requests for newer MTK modems.
  * rilmodem, mtk.c, ril.c: add auto-answer support
    This change adds auto-answer support which is triggered
    by usage of a special test SIM (MCC/MNC 001/01 or 001/001).
  * mtkmodem, unit, mtk.c: support arale firmware switch
    This change will cause the correct modem firmware to
    be loaded based upon the SIM MCC and MNC. If new
    firmware is loaded, a modem reset is triggered.
  * mtkmodem, unit, mtk.c: handle suspend events
    RIL_RESUME_REGISTRATION requests are not sent to
    MTK modems if suspend events are received.
  * gril, include, mbpi, rilmodem, mtkmodem, rilmodem,
    gprs, unit, modem, ril.c, mtk.c: LTE updates
    This changes detection logic for LTE modems to rilmodem
    ( via an environment var ) and mtkmodem ( via a modem
    query ). If detected, a RIL_INITIAL_ATTACH_APN request
    is not sent to the modem during gprs initialization.
 -- Ubuntu daily release <email address hidden> Wed, 04 Feb 2015 09:18:00 +0000