[mako, no-SIM] RadioSettings should not be available in flight mode

[Tony Espy]

When a mako with no SIM has FlightMode enabled, the following is the output of list-modems:

[ /ril_0 ]
    Type = hardware
    Lockdown = 0
    Manufacturer = Fake Manufacturer
    Interfaces = org.ofono.RadioSettings org.ofono.CallVolume org.ofono.VoiceCallManager org.ofono.SimManager
    Revision = M9615A-CEFWMAZM-2.0.1700.98
    Powered = 1
    Emergency = 0
    Model = Fake Modem Model
    Online = 0
    Serial = 355136052481127
    Features = rat sim
    [ org.ofono.RadioSettings ]
        FastDormancy = 0
        ModemTechnologies = gsm umts
        TechnologyPreference = umts
    [ org.ofono.CallVolume ]
        SpeakerVolume = 0
        MicrophoneVolume = 0
        Muted = 1
    [ org.ofono.VoiceCallManager ]
        EmergencyNumbers = 08 000 999 110 112 911 118 119
    [ org.ofono.SimManager ]
        Present = 0

If the device is re-booted, then output of list-modems looks like this:

[ /ril_0 ]
    Emergency = 0
    Model = Fake Modem Model
    Online = 0
    Serial = 355136052481127
    Features = sim
    Powered = 1
    Manufacturer = Fake Manufacturer
    Interfaces = org.ofono.SimManager org.ofono.CallVolume
                 org.ofono.VoiceCallManager
    Revision = M9615A-CEFWMAZM-2.0.1700.98
    Lockdown = 0
    Type = hardware
    [ org.ofono.SimManager ]
        Present = 0
    [ org.ofono.CallVolume ]
        SpeakerVolume = 0
        Muted = 1
        MicrophoneVolume = 0
    [ org.ofono.VoiceCallManager ]
        EmergencyNumbers = 08 000 999 110 112 911 118 119

This bug is being reported against ubuntu-rtm/14.09 propposed image #135. The version of ofono is:

1.12.bzr6882+14.10.20141103~rtm-0ubuntu1

This bug is mako-specific.

[Tony Espy (awe)]

This is not a regression, as prior to installing the above-mentioned version of ofono, no interfaces are created, including the SimManager which exposes the Present property. Here's the output of list-modems in the same scenario with the prior version:

[ /ril_0 ]
    Type = hardware
    Features =
    Lockdown = 0
    Emergency = 0
    Model = Fake Modem Model
    Serial = 355136052481127
    Online = 0
    Manufacturer = Fake Manufacturer
    Revision = M9615A-CEFWMAZM-2.0.1700.98
    Powered = 1
    Interfaces =

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

Fix proposed in PR

https://github.com/rilmodem/ofono/pull/116

[Tony Espy (awe)]

The proposed fix was merged, and fixes most of the original problem. At this point, the only discrepancy is that RadioSettings is available if no SIM is present, and the modem set offline ( eg. FlightMode enabled ), however after a reboot in this state, RadioSettings is no longer available.

[Alfonso Sanchez-Beato (alfonsosanchezbeato)]

RadioSettings is not supposed to be available when the modem is offline, as you cannot set low power mode off if the modem is offline, and you cannot set or know the current technology at that state. So the bug is that RadioSettings should not be available when you activate flight mode.

[Tony Espy (awe)]

Agreed.

[Tony Espy (awe)]

Except that I can *only* reproduce this if there's no SIM.

If a SIM is installed and FlightMode enabled, no RadioSettings is available.

[Tony Espy (awe)]

Tested on mako/rtm/stable #16.