Battery page must not use NM WifiEnabled property to disable Wi-Fi

[Nick Dedekind]

Switching wifi on/off from battery settings works with the actual network, but the indicator switch does not seem to update.

[Antti Kaijanmäki (kaijanmaki)]

When you see the switch item inside the indicator being in wrong state please run

$ dbus-send --session --dest=com.canonical.indicator.network --print-reply /com/canonical/indicator/network org.gtk.Actions.Describe string:wifi.enable

and paste the output here.

[Ken VanDine (ken-vandine)]

   struct {
      boolean true
      signature ""
      array [
         variant boolean true
      ]
   }

[Antti Kaijanmäki (kaijanmaki)]

Never mind. found this from Battery plugin:

void Battery::setWifiEnabled(bool enabled)
{
    nm_client_wireless_set_enabled (m_nm_client, enabled);
}

System Settings _must not_ try to control the wifi through NM dbus-api directly. For short term, please see how the Wi-Fi panel does this inside plugins/wifi/PageComponent.qml

Simply trying to control the Wi-Fi through NM API will not power down the wifi chipset. This needs to be fixed ASAP.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.3+15.04.20141112.1-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.04.20141112.1-0ubuntu1) vivid; urgency=low

  [ Sebastien Bacher ]
  * Update the translations template during the build (LP: #1389786)

  [ jonas-drange ]
  * [cellular][phone] titles now using SettingsItemTitle (LP: #1389767)
  * [wifi] fix multiple issues in the "Connect to other network" dialog
    (LP: #1387656)

  [ Andrea Cimitan ]
  * Delay password set/confirm screens after entering the 4th digit,
    fixing 1390557 (LP: #1390557)

  [ CI bot ]
  * Resync trunk

  [ Ken VanDine ]
  * Specify DaemonVersion for upower to support upower 0.99 on vivid
    (LP: #1390629)
  * [battery] don't control wifi state with libnm, use the
    QDBusActionGroup from indicator-network (LP: #1391940)

  [ Christian Dywan ]
  * Remove the dialog internals resizing hack (LP: #1376763)
 -- Ubuntu daily release <email address hidden> Wed, 12 Nov 2014 19:27:21 +0000

[Matthew Paul Thomas (mpt)]

I suggest that the Wi-Fi toggle, label and all, should be a component that is used by the Wi-Fi screen, the Battery screen, and the network indicator. That would have avoided this bug, and a similar future bug when hotspot is implemented. (Specifically, the label should change from "Wi-Fi" to "Wi-Fi used for Hotspot" when it's on; if the item is implemented three places, the odds of all three behaving identically are low.)

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.3+15.04.20141209~rtm-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.04.20141209~rtm-0ubuntu1) 14.09; urgency=low

  [ Ken VanDine ]
  * [battery] don't control wifi state with libnm, use the
    QDBusActionGroup from indicator-network (LP: #1391940)
  * Update the translations template during the build (LP: #1399212)
  * Use the SliderMenu component instead of the Slider component to
    fixed value binding issues
 -- Ubuntu daily release <email address hidden> Tue, 09 Dec 2014 14:16:59 +0000