Grid view: display only one featured image
Bug #1218201 reported by
David Planella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Shorts App |
Fix Released
|
High
|
Unassigned | ||
Bug Description
In the grid view, in certain posts we are showing two featured images
http://
Looking at the design spec, we should be showing only one image. For the first implementation, I'd keep the rules simple:
1) Pick only the first image in the post and use it as the featured image in the grid
2) But make sure it is of a certain size, otherwise pick the next or don't show an image (see bug 1218198)
See the attached screenshot that illustrates the issue.
Related branches
lp:~qqworini/ubuntu-rssreader-app/new-gridview2
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Roman Shchekin: Approve
-
Diff: 1673 lines (+318/-1074)12 files modifiedListColumnDelegate.qml (+0/-62)
ListColumnView.qml (+0/-119)
OrganicGrid.qml (+227/-0)
RssFeedPage.qml (+3/-3)
TopicTab.qml (+3/-3)
addDelegate.js (+0/-153)
article_items/ArticleFullImg.qml (+31/-91)
article_items/ArticleOneImgA.qml (+25/-85)
article_items/ArticleOneImgB.qml (+0/-180)
article_items/ArticleTextA.qml (+15/-59)
article_items/ArticleTextB.qml (+14/-63)
article_items/ArticleTwoImgA.qml (+0/-256)
Revision history for this message
| David Planella (dpm) wrote | #1 |
| Changed in ubuntu-rssreader-app: | |
| status: | New → Triaged |
| importance: | Undecided → High |
Revision history for this message
| Sam Bull (dreamsorcerer) wrote | #2 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #3 |
| Changed in ubuntu-rssreader-app: | |
| status: | Triaged → Fix Committed |
| Changed in ubuntu-rssreader-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Just to note, the current implementation works quite well for Planet GNOME, where the two pictures will be the hackergotchi for the person posting and a featured image from the post.