ubuntu-push is flooding dbus with NameOwnerChanged signals
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Critical
|
Bill Filler | ||
| Ubuntu Push Notifications |
Fix Released
|
High
|
Jonas G. Drange | ||
Bug Description
NM 1.2 has stricter handling of property names due to it's move from using dbus-glib to gdbus internally.
ubuntu-push has been using the top-level NM property name 'state', which now results in a DBus error when it's value is queried, whereas this worked OK with NM 0.9.10.
I've verified both in upstream's documentation and the code that the property has always been 'State', even in 0.9.10.
On a recent system with
$ system-image-cli -i
current build number: 59
device name: turbo
channel: ubuntu-
last update: 2016-04-25 08:07:52
version version: 59
version ubuntu: 20160423
version device: 20160412-d272a77
version custom: 20160324-945-18-69
ubuntu-push is spamming dbus with NameOwnerChanged signals constantly
root@ubuntu-
sig 1461676597 952956 2 /org/freedeskto
sig 1461676597 967580 35919 /org/freedeskto
sig 1461676597 979623 35920 /org/freedeskto
sig 1461676597 995234 35921 /org/freedeskto
sig 1461676598 7504 35922 /org/freedeskto
sig 1461676598 25708 35923 /org/freedeskto
sig 1461676598 37448 35924 /org/freedeskto
sig 1461676598 52701 35925 /org/freedeskto
sig 1461676598 65064 35926 /org/freedeskto
sig 1461676598 83597 35927 /org/freedeskto
sig 1461676598 101992 35928 /org/freedeskto
sig 1461676598 117352 35929 /org/freedeskto
sig 1461676598 129604 35930 /org/freedeskto
[...]
This is causing ubuntu-
Running
$ stop ubuntu-push-client
stops the flood.
Related branches
- Simon Fels: Approve
-
Diff: 25 lines (+2/-2)2 files modifiedbus/connectivity/connectivity_test.go (+1/-1)
bus/networkmanager/networkmanager.go (+1/-1)
- Ubuntu Push Hackers: Pending requested
-
Diff: 65 lines (+3/-7)6 files modifiedbus/connectivity/connectivity_test.go (+1/-1)
bus/networkmanager/networkmanager.go (+1/-1)
client/service/postal_test.go (+1/-0)
debian/source/format (+0/-1)
docs/example-server/.bzrignore (+0/-1)
docs/example-server/.gitignore (+0/-3)
- Ubuntu Push Hackers: Pending requested
-
Diff: 84 lines (+34/-15)2 files modifiedclient/service/postal.go (+17/-14)
client/service/postal_test.go (+17/-1)
| description: | updated |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Bill Filler (bfiller) |
| importance: | Undecided → High |
| milestone: | none → 11 |
| status: | New → Confirmed |
| Changed in ubuntu-push: | |
| assignee: | nobody → Jonas G. Drange (jonas-drange) |
| importance: | Undecided → High |
| status: | New → Confirmed |
| Changed in ubuntu-push: | |
| status: | Confirmed → In Progress |
| description: | updated |
| Changed in canonical-devices-system-image: | |
| importance: | High → Critical |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-push: | |
| status: | In Progress → Fix Released |
