ubuntu-push is flooding dbus with NameOwnerChanged signals

Bug #1575184 reported by Simon Fels
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Critical
Bill Filler
Ubuntu Push Notifications
Fix Released
High
Jonas G. Drange

Bug Description

NM 1.2 has stricter handling of property names due to it's move from using dbus-glib to gdbus internally.

ubuntu-push has been using the top-level NM property name 'state', which now results in a DBus error when it's value is queried, whereas this worked OK with NM 0.9.10.

I've verified both in upstream's documentation and the code that the property has always been 'State', even in 0.9.10.

https://developer.gnome.org/NetworkManager/1.2/gdbus-org.freedesktop.NetworkManager.html#gdbus-property-org-freedesktop-NetworkManager.State

On a recent system with

$ system-image-cli -i
current build number: 59
device name: turbo
channel: ubuntu-touch/rc-proposed/meizu.en
last update: 2016-04-25 08:07:52
version version: 59
version ubuntu: 20160423
version device: 20160412-d272a77
version custom: 20160324-945-18-69

ubuntu-push is spamming dbus with NameOwnerChanged signals constantly

root@ubuntu-phablet:~# dbus-monitor --system --profile
sig 1461676597 952956 2 /org/freedesktop/DBus org.freedesktop.DBus NameAcquired
sig 1461676597 967580 35919 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676597 979623 35920 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676597 995234 35921 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676598 7504 35922 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676598 25708 35923 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676598 37448 35924 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676598 52701 35925 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676598 65064 35926 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676598 83597 35927 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676598 101992 35928 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676598 117352 35929 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
sig 1461676598 129604 35930 /org/freedesktop/DBus org.freedesktop.DBus NameOwnerChanged
[...]

This is causing ubuntu-push/dbus-daemon to cause a CPU load of 40% per process.

Running

$ stop ubuntu-push-client

stops the flood.

Related branches

Revision history for this message
Simon Fels (morphis) wrote :
description: updated
description: updated
Changed in canonical-devices-system-image:
assignee: nobody → Bill Filler (bfiller)
importance: Undecided → High
milestone: none → 11
status: New → Confirmed
Changed in ubuntu-push:
assignee: nobody → Jonas G. Drange (jonas-drange)
importance: Undecided → High
status: New → Confirmed
Changed in ubuntu-push:
status: Confirmed → In Progress
Tony Espy (awe)
description: updated
Changed in canonical-devices-system-image:
importance: High → Critical
Changed in canonical-devices-system-image:
status: Confirmed → Fix Committed
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
Changed in ubuntu-push:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers